[heap] Reland: Make SlotSet allocation thread-safe and refactor code.

[heap] Reland: Make SlotSet allocation thread-safe and refactor code.

BUG=chromium:694255
Review-Url: https://codereview.chromium.org/2783873002
Cr-Commit-Position: refs/heads/master@{#44236}
Committed: https://chromium.googlesource.com/v8/v8/+/d0c06a7b95c5148284cf1185490e944a2b5ddd31

[Hannes Payer (out of office), 2017-03-29 14:34:56]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2017-03-29 14:41:49]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2017-03-29 14:41:50]

lgtm

https://codereview.chromium.org/2783873002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2783873002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3550: if (typed_slot_set != nullptr &&
slots_clearing_mode == CLEAR_TYPED_SLOTS) {
How about putting the type_slot_set inside the branch to make the non-clearing
case faster?

if (slots_clearing_mode == CLEAR_TYPED_SLOTS) {
  TypedSlotSet* typed_slot_set = p->typed_slot_set<OLD_TO_NEW>();
  if (typed_slot_set != nullptr) { ... }
}

[Hannes Payer (out of office), 2017-03-29 14:53:15]

https://codereview.chromium.org/2783873002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2783873002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3550: if (typed_slot_set != nullptr &&
slots_clearing_mode == CLEAR_TYPED_SLOTS) {
On 2017/03/29 14:41:50, ulan wrote:
> How about putting the type_slot_set inside the branch to make the non-clearing
> case faster?
> 
> if (slots_clearing_mode == CLEAR_TYPED_SLOTS) {
>   TypedSlotSet* typed_slot_set = p->typed_slot_set<OLD_TO_NEW>();
>   if (typed_slot_set != nullptr) { ... }
> }

Done.

[Hannes Payer (out of office), 2017-03-29 14:53:19]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-03-29 14:53:19]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2783873002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2017-03-29 14:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 15:17:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490799199250730,
"parent_rev": "a82418780d88ca6639dbe0c8f4be67125023a69e", "commit_rev":
"d0c06a7b95c5148284cf1185490e944a2b5ddd31"}

[commit-bot: I haz the power, 2017-03-29 15:17:37]

Description was changed from

==========
[heap] Reland: Make SlotSet allocation thread-safe and refactor code.

BUG=chromium:694255
==========

to

==========
[heap] Reland: Make SlotSet allocation thread-safe and refactor code.

BUG=chromium:694255

Review-Url: https://codereview.chromium.org/2783873002
Cr-Commit-Position: refs/heads/master@{#44236}
Committed:
https://chromium.googlesource.com/v8/v8/+/d0c06a7b95c5148284cf1185490e944a2b5...
==========

[commit-bot: I haz the power, 2017-03-29 15:17:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/d0c06a7b95c5148284cf1185490e944a2b5...