Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2783823004: chromeos: Add D-Bus config for org.chromium.NetworkProxyService. (Closed)

Created:
3 years, 8 months ago by Daniel Erat
Modified:
3 years, 8 months ago
Reviewers:
teravest
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add D-Bus config for org.chromium.NetworkProxyService. Add a D-Bus config file letting chronos own the org.chromium.NetworkProxyService service name and letting all processes make calls to it. BUG=703217 Review-Url: https://codereview.chromium.org/2783823004 Cr-Commit-Position: refs/heads/master@{#460643} Committed: https://chromium.googlesource.com/chromium/src/+/34a136576bbddba2bc7cbd1bc6fc82a6c979b151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/services/README.md View 1 chunk +5 lines, -3 lines 0 comments Download
A chromeos/dbus/services/org.chromium.NetworkProxyService.conf View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Daniel Erat
3 years, 8 months ago (2017-03-30 00:58:17 UTC) #3
teravest
lgtm
3 years, 8 months ago (2017-03-30 01:21:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783823004/1
3 years, 8 months ago (2017-03-30 01:32:59 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:30:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34a136576bbddba2bc7cbd1bc6fc...

Powered by Google App Engine
This is Rietveld 408576698