Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2783823002: Fix compilation issue with base::flat_map. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
danakj, brettw
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation issue with base::flat_map. Does not compile for flat_map<base::StringPiece, base::TimeDelta> without this fix. BUG=none TEST=none Review-Url: https://codereview.chromium.org/2783823002 Cr-Commit-Position: refs/heads/master@{#460541} Committed: https://chromium.googlesource.com/chromium/src/+/b2f307761e5a1ab5793aafd3f659712f24fb0cea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/containers/flat_map.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
DaleCurtis
Assuming this was intended but left out on the initial CL. Not sure why it ...
3 years, 8 months ago (2017-03-29 01:47:00 UTC) #2
brettw
lgtm
3 years, 8 months ago (2017-03-29 16:29:29 UTC) #3
danakj
LGTM can you paste what the compile error was? Am curious
3 years, 8 months ago (2017-03-29 18:11:27 UTC) #4
DaleCurtis
In file included from ../../content/browser/media/media_internals.cc:12: ../../base/containers/flat_map.h:243:13: error: use of undeclared identifier 'unsafe_emplace' found = unsafe_emplace(found, ...
3 years, 8 months ago (2017-03-29 19:55:07 UTC) #6
DaleCurtis
While working on https://codereview.chromium.org/2780533004
3 years, 8 months ago (2017-03-29 19:55:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783823002/1
3 years, 8 months ago (2017-03-29 19:55:39 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:31:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2f307761e5a1ab5793aafd3f659...

Powered by Google App Engine
This is Rietveld 408576698