Fix compilation issue with base::flat_map.

Fix compilation issue with base::flat_map.

Does not compile for flat_map<base::StringPiece, base::TimeDelta>
without this fix.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2783823002
Cr-Commit-Position: refs/heads/master@{#460541}
Committed: https://chromium.googlesource.com/chromium/src/+/b2f307761e5a1ab5793aafd3f659712f24fb0cea

[DaleCurtis, 2017-03-29 01:47:00]

dalecurtis@chromium.org changed reviewers:
+ brettw@chromium.org, danakj@chromium.org

[DaleCurtis, 2017-03-29 01:47:00]

Assuming this was intended but left out on the initial CL. Not sure why it
passed compilation; there are tests for map[key] = value. There must be
something special about the StringPiece, TimeDelta setup. Happy to add a test if
it's apparent what that magic is, it's not to me.

[brettw, 2017-03-29 16:29:29]

lgtm

[danakj, 2017-03-29 18:11:27]

LGTM can you paste what the compile error was? Am curious

[DaleCurtis, 2017-03-29 19:55:06]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-03-29 19:55:07]

In file included from ../../content/browser/media/media_internals.cc:12:
../../base/containers/flat_map.h:243:13: error: use of undeclared identifier
'unsafe_emplace'
    found = unsafe_emplace(found, key, Mapped());
            ^
            this->
../../content/browser/media/media_internals.cc:462:29: note: in instantiation of
member function 'base::flat_map<base::BasicStringPiece<std::string>,
base::TimeDelta, std::less<base::BasicStringPiece<std::string> > >::operator[]'
requested here
        info.watch_time_info[*key_name] =
                            ^
../../base/containers/flat_tree.h:253:12: note: must qualify identifier to find
this declaration in dependent base class
  iterator unsafe_emplace(const_iterator position, Args&&... args);

[DaleCurtis, 2017-03-29 19:55:32]

While working on https://codereview.chromium.org/2780533004

[commit-bot: I haz the power, 2017-03-29 19:55:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 21:30:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490817306614830, "parent_rev":
"3584247ed72a9c63da351e4042d8208334bcc591", "commit_rev":
"b2f307761e5a1ab5793aafd3f659712f24fb0cea"}

[commit-bot: I haz the power, 2017-03-29 21:31:43]

Description was changed from

==========
Fix compilation issue with base::flat_map.

Does not compile for flat_map<base::StringPiece, base::TimeDelta>
without this fix.

BUG=none
TEST=none
==========

to

==========
Fix compilation issue with base::flat_map.

Does not compile for flat_map<base::StringPiece, base::TimeDelta>
without this fix.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2783823002
Cr-Commit-Position: refs/heads/master@{#460541}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2f307761e5a1ab5793aafd3f659...
==========

[commit-bot: I haz the power, 2017-03-29 21:31:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2f307761e5a1ab5793aafd3f659...