Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 2783773002: Link PasswordProtectionService to Profile and SB Service (Closed)
Patch Set: RemovePasswordProtectionService(..) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index ab47052c96be95722605304c13d729aa32eed287..adcf1cd4aa9fefb71a5acfd86657ff27f8295dd7 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -104,6 +104,11 @@ class ChromePasswordManagerClient
void GenerationAvailableForForm(const autofill::PasswordForm& form) override;
void HidePasswordGenerationPopup() override;
+#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
+ safe_browsing::PasswordProtectionService* GetPasswordProtectionService()
Nathan Parker 2017/04/03 20:33:34 Re: SAFE_BROWSING_DB_REMOTE -- On Android we don't
Jialiu Lin 2017/04/03 20:45:12 Thanks for pointing this out. It completely slippe
+ const override;
+#endif
+
static void CreateForWebContentsWithAutofillClient(
content::WebContents* contents,
autofill::AutofillClient* autofill_client);
@@ -161,12 +166,6 @@ class ChromePasswordManagerClient
// without custom sync passphrase.
static bool ShouldAnnotateNavigationEntries(Profile* profile);
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
- // Return true if we can set PasswordProtectionService in
- // |password_reuse_detection_manager_|.
- static bool CanSetPasswordProtectionService();
-#endif
-
Profile* const profile_;
password_manager::PasswordManager password_manager_;

Powered by Google App Engine
This is Rietveld 408576698