Link PasswordProtectionService to Profile and SB Service

chrome/browser/password_manager/chrome_password_manager_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 86 matching lines @@
   void ShowPasswordGenerationPopup(const gfx::RectF& bounds,
                                    int max_length,
                                    const base::string16& generation_element,
                                    bool is_manually_triggered,
                                    const autofill::PasswordForm& form) override;
   void ShowPasswordEditingPopup(const gfx::RectF& bounds,
                                 const autofill::PasswordForm& form) override;
   void GenerationAvailableForForm(const autofill::PasswordForm& form) override;
   void HidePasswordGenerationPopup() override;
 
+#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
+  safe_browsing::PasswordProtectionService* GetPasswordProtectionService()

[Nathan Parker, 2017/04/03 20:33:34]

Re: SAFE_BROWSING_DB_REMOTE -- On Android we don't yet have the CSD Whitelist
(tracked in http://b/36806770), and it'll fail on a NOTREACHED() if you call
MatchCsdWhitelistUrl().  So we should keep this all disabled on
SAFE_BROWSING_DB_REMOTE until then.  You could do that here, or keep it here and
disable it someplace further down.

[Jialiu Lin, 2017/04/03 20:45:12]

Thanks for pointing this out. It completely slipped my mind. I'll make sure it
is gated in password_reuse_detection_manager.cc (where the actual calling
happens).

+      const override;
+#endif
+
   static void CreateForWebContentsWithAutofillClient(
       content::WebContents* contents,
       autofill::AutofillClient* autofill_client);
 
   // Observer for PasswordGenerationPopup events. Used for testing.
   void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer);
 
   static void BindCredentialManager(
       content::RenderFrameHost* render_frame_host,
       password_manager::mojom::CredentialManagerRequest request);
@@ skipping 37 matching lines @@
   // means that nothing was chosen. |one_local_credential| is true if there was
   // just one local credential to be chosen from.
   void OnCredentialsChosen(const CredentialsCallback& callback,
                            bool one_local_credential,
                            const autofill::PasswordForm* form);
 
   // Returns true if this profile has metrics reporting and active sync
   // without custom sync passphrase.
   static bool ShouldAnnotateNavigationEntries(Profile* profile);
 
-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
-  // Return true if we can set PasswordProtectionService in
-  // |password_reuse_detection_manager_|.
-  static bool CanSetPasswordProtectionService();
-#endif
-
   Profile* const profile_;
 
   password_manager::PasswordManager password_manager_;
 
   password_manager::PasswordReuseDetectionManager
       password_reuse_detection_manager_;
 
   password_manager::ContentPasswordManagerDriverFactory* driver_factory_;
 
   // As a mojo service, will be registered into service registry
@@ skipping 20 matching lines @@
   std::unique_ptr<password_manager::LogManager> log_manager_;
 
   // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the
   // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
   std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_