|
|
Created:
3 years, 8 months ago by Tom (Use chromium acct) Modified:
3 years, 8 months ago CC:
chromium-reviews, dominicc+watchlist_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGcc: Suppress warnings in third_party
There's a bit of warning spam when building chrome using gcc. This CL
suppresses the warnings like we do when using clang.
BUG=697528
R=dominicc@chromium.org,dalecurtis@chromium.org
Review-Url: https://codereview.chromium.org/2783763002
Cr-Commit-Position: refs/heads/master@{#460361}
Committed: https://chromium.googlesource.com/chromium/src/+/aaadc0e2555e316a95b0aaa3fcacb8dcdc2d8044
Patch Set 1 #Patch Set 2 : add is_linux #
Messages
Total messages: 30 (24 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reviewers ptal dominicc: libxml dalecurtis: yasm
yasm lgtm
(though that seems like a bug, so if you're feeling nice, submitting a fix upstream would be cool)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CQ has no permission to schedule in bucket master.tryserver.chromium.linux
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CQ has no permission to schedule in bucket master.tryserver.chromium.linux
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dominicc@chromium.org
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org Link to the patchset: https://codereview.chromium.org/2783763002/#ps20001 (title: "add is_linux")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490791465629790, "parent_rev": "aa1586759de407c9631115b3de0ea85acb5b622f", "commit_rev": "aaadc0e2555e316a95b0aaa3fcacb8dcdc2d8044"}
Message was sent while issue was closed.
Description was changed from ========== Gcc: Suppress warnings in third_party There's a bit of warning spam when building chrome using gcc. This CL suppresses the warnings like we do when using clang. BUG=697528 R=dominicc@chromium.org,dalecurtis@chromium.org ========== to ========== Gcc: Suppress warnings in third_party There's a bit of warning spam when building chrome using gcc. This CL suppresses the warnings like we do when using clang. BUG=697528 R=dominicc@chromium.org,dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2783763002 Cr-Commit-Position: refs/heads/master@{#460361} Committed: https://chromium.googlesource.com/chromium/src/+/aaadc0e2555e316a95b0aaa3fcac... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/aaadc0e2555e316a95b0aaa3fcac... |