Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2783763002: Gcc: Suppress warnings in third_party (Closed)

Created:
3 years, 8 months ago by Tom (Use chromium acct)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gcc: Suppress warnings in third_party There's a bit of warning spam when building chrome using gcc. This CL suppresses the warnings like we do when using clang. BUG=697528 R=dominicc@chromium.org,dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2783763002 Cr-Commit-Position: refs/heads/master@{#460361} Committed: https://chromium.googlesource.com/chromium/src/+/aaadc0e2555e316a95b0aaa3fcacb8dcdc2d8044

Patch Set 1 #

Patch Set 2 : add is_linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/libxml/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/yasm/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
Tom (Use chromium acct)
reviewers ptal dominicc: libxml dalecurtis: yasm
3 years, 8 months ago (2017-03-28 20:55:36 UTC) #3
DaleCurtis
yasm lgtm
3 years, 8 months ago (2017-03-28 21:00:11 UTC) #4
DaleCurtis
(though that seems like a bug, so if you're feeling nice, submitting a fix upstream ...
3 years, 8 months ago (2017-03-28 21:00:42 UTC) #5
dominicc (has gone to gerrit)
lgtm
3 years, 8 months ago (2017-03-29 12:44:26 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783763002/20001
3 years, 8 months ago (2017-03-29 12:44:43 UTC) #27
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 12:49:17 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aaadc0e2555e316a95b0aaa3fcac...

Powered by Google App Engine
This is Rietveld 408576698