Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2783713002: Separate module max memory pages counter for asm.js/WASM. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Separate module max memory pages counter for asm.js/WASM. Currently, V* uses the same size counter to measure the maximum number of memory pages allocated by a module for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when measuring. BUG=chromium:704922 R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2783713002 Cr-Commit-Position: refs/heads/master@{#44210} Committed: https://chromium.googlesource.com/v8/v8/+/90c12512d9f79ab9603db86d228df200e581880b

Patch Set 1 #

Patch Set 2 : Fix merge conflicts with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/counters.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
kschimpf
Please review. Thanks.
3 years, 8 months ago (2017-03-28 16:26:27 UTC) #6
bradnelson
lgtm
3 years, 8 months ago (2017-03-28 18:13:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783713002/1
3 years, 8 months ago (2017-03-28 18:13:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37875)
3 years, 8 months ago (2017-03-28 18:19:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783713002/20001
3 years, 8 months ago (2017-03-28 20:09:18 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 21:22:25 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/90c12512d9f79ab9603db86d228df200e58...

Powered by Google App Engine
This is Rietveld 408576698