Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2783673003: Separate stubs for V4L2 and VAAPI. (Closed)

Created:
3 years, 8 months ago by pbos
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate stubs for V4L2 and VAAPI. Permits building Chromium with both V4L2 and VAAPI. Before this change when building with use_v4lplugin set on non-arm platforms generate_stubs.py would be called to generate two InitializeStubs() functions (and other symbols) under the media_gpu namespace, breaking the one-definition rule and failing to link both VAAPI and V4L2. R=posciak@chromium.org BUG=709175 TEST=Compile Zako with use_v4lplugin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2783673003 Cr-Commit-Position: refs/heads/master@{#466319} Committed: https://chromium.googlesource.com/chromium/src/+/377f6d9ede58daddce19df03bbb2a280c4afc550

Patch Set 1 #

Patch Set 2 : reference correct va_stubs.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -83 lines) Patch
M media/gpu/BUILD.gn View 1 5 chunks +14 lines, -14 lines 0 comments Download
M media/gpu/generic_v4l2_device.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D media/gpu/v4l2.sig View 1 chunk +0 lines, -10 lines 0 comments Download
A + media/gpu/v4l2/v4l2.sig View 0 chunks +-1 lines, --1 lines 0 comments Download
D media/gpu/va.sigs View 1 chunk +0 lines, -36 lines 0 comments Download
D media/gpu/va_drm.sigs View 1 chunk +0 lines, -8 lines 0 comments Download
D media/gpu/va_x11.sigs View 1 chunk +0 lines, -9 lines 0 comments Download
A + media/gpu/vaapi/va.sigs View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/gpu/vaapi/va_drm.sigs View 0 chunks +-1 lines, --1 lines 0 comments Download
A + media/gpu/vaapi/va_x11.sigs View 0 chunks +-1 lines, --1 lines 0 comments Download
M media/gpu/vaapi_wrapper.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 39 (17 generated)
pbos
PTAL
3 years, 8 months ago (2017-03-28 21:26:50 UTC) #2
pbos
On 2017/03/28 21:26:50, pbos wrote: > PTAL This moves *sigs to vaapi/ and v4l2/ subdirectories ...
3 years, 8 months ago (2017-03-28 21:27:41 UTC) #3
DaleCurtis
If we're creating folders, want to go ahead and create media/gpu/cros ? or /linux if ...
3 years, 8 months ago (2017-03-28 21:29:04 UTC) #5
pbos
On 2017/03/28 21:29:04, DaleCurtis wrote: > If we're creating folders, want to go ahead and ...
3 years, 8 months ago (2017-03-28 21:30:07 UTC) #6
DaleCurtis
context: https://codereview.chromium.org/2705153006
3 years, 8 months ago (2017-03-28 21:33:04 UTC) #7
pbos
On 2017/03/28 21:33:04, DaleCurtis wrote: > context: https://codereview.chromium.org/2705153006 I'd like to defer that to when ...
3 years, 8 months ago (2017-03-28 21:40:30 UTC) #8
DaleCurtis
Sorry, I wasn't suggesting that. I was suggesting the move is done first then this ...
3 years, 8 months ago (2017-03-28 21:43:06 UTC) #9
pbos
On 2017/03/28 21:43:06, DaleCurtis wrote: > Sorry, I wasn't suggesting that. I was suggesting the ...
3 years, 8 months ago (2017-03-28 21:44:30 UTC) #10
Pawel Osciak
If everyone is ok with that, I'm happy to reorganize the folders. I'll have a ...
3 years, 8 months ago (2017-03-29 00:40:23 UTC) #11
pbos
On 2017/03/29 00:40:23, Pawel Osciak wrote: > If everyone is ok with that, I'm happy ...
3 years, 8 months ago (2017-03-29 15:10:47 UTC) #12
Pawel Osciak
On 2017/03/29 15:10:47, pbos wrote: > On 2017/03/29 00:40:23, Pawel Osciak wrote: > > If ...
3 years, 8 months ago (2017-03-31 08:30:12 UTC) #13
pbos
On 2017/03/31 08:30:12, Pawel Osciak wrote: > On 2017/03/29 15:10:47, pbos wrote: > > On ...
3 years, 8 months ago (2017-04-03 16:31:42 UTC) #14
pbos
On 2017/04/03 16:31:42, pbos wrote: > On 2017/03/31 08:30:12, Pawel Osciak wrote: > > On ...
3 years, 8 months ago (2017-04-06 20:09:35 UTC) #16
Pawel Osciak
On 2017/04/06 20:09:35, pbos wrote: > On 2017/04/03 16:31:42, pbos wrote: > > On 2017/03/31 ...
3 years, 8 months ago (2017-04-20 08:36:06 UTC) #17
Pawel Osciak
On 2017/04/20 08:36:06, Pawel Osciak wrote: > On 2017/04/06 20:09:35, pbos wrote: > > On ...
3 years, 8 months ago (2017-04-20 09:14:03 UTC) #18
pbos
reference correct va_stubs.h
3 years, 8 months ago (2017-04-20 14:16:29 UTC) #23
pbos
On 2017/04/20 09:14:03, Pawel Osciak wrote: > On 2017/04/20 08:36:06, Pawel Osciak wrote: > > ...
3 years, 8 months ago (2017-04-20 14:17:14 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783673003/20001
3 years, 8 months ago (2017-04-20 14:17:36 UTC) #27
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-20 14:17:41 UTC) #29
Pawel Osciak
Thanks, I also tested this on ARM and Intel CrOS manually. lgtm
3 years, 8 months ago (2017-04-21 04:17:09 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783673003/20001
3 years, 8 months ago (2017-04-21 12:45:36 UTC) #36
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 12:50:50 UTC) #39
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/377f6d9ede58daddce19df03bbb2...

Powered by Google App Engine
This is Rietveld 408576698