Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2783663002: [selectors-4] Import more tests from W3C repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 4 weeks ago by Manuel Rego
Modified:
1 month, 4 weeks ago
Reviewers:
jfernandez, qyearsley, kochi
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[selectors-4] Import more tests from W3C repository On the first import we forgot to import the tests from Mozilla. From the new imported tests only 1 is passing right now. Again the other miss :dir (crbug.com/576815) and :focus-within (crbug.com/617371) implementations. BUG=704902 Review-Url: https://codereview.chromium.org/2783663002 Cr-Commit-Position: refs/heads/master@{#460097} Committed: https://chromium.googlesource.com/chromium/src/+/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/child-index-no-parent-01.html View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/child-index-no-parent-01-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01a.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01a-expected.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01b.html View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01b-expected.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02a.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02a-expected.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02b.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02b-expected.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03a.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03a-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03b.html View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03b-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-04.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-04-expected.html View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-1.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-1-expected.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-2.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-2-expected.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-3.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-3-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (5 generated)
Manuel Rego
1 month, 4 weeks ago (2017-03-28 13:03:20 UTC) #2
jfernandez
lgtm
1 month, 4 weeks ago (2017-03-28 13:16:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783663002/1
1 month, 4 weeks ago (2017-03-28 13:17:15 UTC) #6
commit-bot: I haz the power
1 month, 4 weeks ago (2017-03-28 14:23:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29f372aa0cdb9b2b6cca4f8bf429...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06