Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 2783633002: Simplify Context usage in MediaNotification (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 8 months ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Context usage in MediaNotification Currently the MediaNotification usages Context objects from many sources, either on service creation, or getting the global ApplicationContext. Actually, using the global ApplicationContext should be sufficient. BUG=705920 Review-Url: https://codereview.chromium.org/2783633002 Cr-Commit-Position: refs/heads/master@{#460350} Committed: https://chromium.googlesource.com/chromium/src/+/0d99ea0a684a3e463a19d9d99f1c0d0a49099f48

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed nits #

Messages

Total messages: 15 (9 generated)
Zhiqiang Zhang (Slow)
3 years, 8 months ago (2017-03-28 12:39:54 UTC) #2
whywhat
Any particular reason to do this change? As learned from the internetz, it seems like ...
3 years, 8 months ago (2017-03-28 19:24:51 UTC) #3
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/2783633002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/2783633002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java#newcode860 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:860: MediaSessionCompat mediaSession = new MediaSessionCompat(getContext(), On 2017/03/28 at 19:24:51, ...
3 years, 8 months ago (2017-03-29 10:35:48 UTC) #4
Zhiqiang Zhang (Slow)
On 2017/03/28 at 19:24:51, avayvod wrote: > Any particular reason to do this change? It's ...
3 years, 8 months ago (2017-03-29 10:39:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783633002/20001
3 years, 8 months ago (2017-03-29 11:13:33 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 11:34:59 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d99ea0a684a3e463a19d9d99f1c...

Powered by Google App Engine
This is Rietveld 408576698