Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2783623002: Extract SuperMemberData from JavaScriptBackend (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract SuperMemberData from JavaScriptBackend Yet another move towards passing all information through data objects computed by previous phases rather than pulling it directly from Backend or Compiler. This is needed to support a shift from model K to model J between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/72fc95113cd65800ab3be8eb55041be83bcaeb43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 4 chunks +27 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-28 10:30:18 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-28 18:19:57 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-03-29 09:55:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
72fc95113cd65800ab3be8eb55041be83bcaeb43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698