Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: pkg/compiler/lib/src/ssa/codegen_helpers.dart

Issue 2783623002: Extract SuperMemberData from JavaScriptBackend (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | tests/compiler/dart2js/inference/inference_test_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/codegen_helpers.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen_helpers.dart b/pkg/compiler/lib/src/ssa/codegen_helpers.dart
index 630309bc8c6a325109078fc593a8fe0ece2a4ceb..a554f18c6b10a0cceac78bc52df1bb7a3adc31d6 100644
--- a/pkg/compiler/lib/src/ssa/codegen_helpers.dart
+++ b/pkg/compiler/lib/src/ssa/codegen_helpers.dart
@@ -334,7 +334,7 @@ class SsaTrustedCheckRemover extends HBaseVisitor {
* t2 = add(4, 3);
*/
class SsaInstructionMerger extends HBaseVisitor {
- final JavaScriptBackend _backend;
+ final SuperMemberData _superMemberData;
/**
* List of [HInstruction] that the instruction merger expects in
* order when visiting the inputs of an instruction.
@@ -353,7 +353,7 @@ class SsaInstructionMerger extends HBaseVisitor {
generateAtUseSite.add(instruction);
}
- SsaInstructionMerger(this.generateAtUseSite, this._backend);
+ SsaInstructionMerger(this.generateAtUseSite, this._superMemberData);
void visitGraph(HGraph graph) {
visitDominatorTree(graph);
@@ -436,7 +436,7 @@ class SsaInstructionMerger extends HBaseVisitor {
// after first access if we use lazy initialization.
// In this case, we therefore don't allow the receiver (the first argument)
// to be generated at use site, and only analyze all other arguments.
- if (!_backend.canUseAliasedSuperMember(superMethod, selector)) {
+ if (!_superMemberData.canUseAliasedSuperMember(superMethod, selector)) {
analyzeInputs(instruction, 1);
} else {
super.visitInvokeSuper(instruction);
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | tests/compiler/dart2js/inference/inference_test_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698