Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2783503002: retry cd95e0083676d5e: Remove some pre-md code and assets. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

retry cd95e0083676d5e: Remove some pre-md code and assets. BUG=687816, 686234, 686335 TBR=tdanderson@chromium.org Review-Url: https://codereview.chromium.org/2783503002 Cr-Commit-Position: refs/heads/master@{#459991} Committed: https://chromium.googlesource.com/chromium/src/+/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -436 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/brightness/tray_brightness.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ash/common/system/chromeos/power/power_status.h View 5 chunks +16 lines, -53 lines 0 comments Download
M ash/common/system/chromeos/power/power_status.cc View 6 chunks +37 lines, -117 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_unittest.cc View 1 2 chunks +32 lines, -27 lines 0 comments Download
M ash/common/system/chromeos/session/tray_session_length_limit.cc View 3 chunks +5 lines, -4 lines 0 comments Download
D ash/common/system/chromeos/settings/tray_settings.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/common/system/chromeos/settings/tray_settings.cc View 1 chunk +0 lines, -175 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +0 lines, -7 lines 0 comments Download
D ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_brightness.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_settings.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_brightness.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_settings.png View Binary file 0 comments Download

Messages

Total messages: 8 (5 generated)
Evan Stade
original is ps1, fix is in ps2. TBR'ing.
3 years, 9 months ago (2017-03-28 00:45:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783503002/20001
3 years, 9 months ago (2017-03-28 00:45:37 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 03:18:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d2bd8f3b6bd8c3911eaa31ef45e...

Powered by Google App Engine
This is Rietveld 408576698