Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2783483002: Updates the gradle dependencies to fix the build. (Closed)

Created:
3 years, 9 months ago by dewittj
Modified:
3 years, 8 months ago
Reviewers:
Yusuf
CC:
carlosk
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updates the gradle dependencies to fix the build. Commit 3c95e2dda9b292653ff13454f093e5ff136814d2 added usages of the following that broke the build as-is: * ContextCompat#startActivity (added in 25.0.0) Updating customtabs/build.gradle fixes the problem. BUG= Review-Url: https://codereview.chromium.org/2783483002 Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/22714ed88155b0d9e7b7b963944935ed7cd7879a

Patch Set 1 #

Patch Set 2 : Revert unneeded line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M customtabs/build.gradle View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
dewittj
PTAL. * I needed to update my SDK so that a reference to com.android.support.annotation.RestrictTo could ...
3 years, 9 months ago (2017-03-28 00:17:31 UTC) #4
Yusuf
lgtm
3 years, 8 months ago (2017-03-30 21:46:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783483002/20001
3 years, 8 months ago (2017-03-30 21:46:36 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:47:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/GoogleChrome/custom-tabs-client/commit/22714ed88155b0d9e7b...

Powered by Google App Engine
This is Rietveld 408576698