Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2783463002: Disable TruncatedTrace unit test if exclude_unwind_tables used (Closed)

Created:
3 years, 9 months ago by halliwell
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TruncatedTrace unit test if exclude_unwind_tables used Chromecast is now using exclude_unwind_tables, and it causes this test to fail. BUG=internal b/36082628 Review-Url: https://codereview.chromium.org/2783463002 Cr-Commit-Position: refs/heads/master@{#459993} Committed: https://chromium.googlesource.com/chromium/src/+/5e1e4faa96970748940416fc9068551cd897c344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/debug/stack_trace_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
halliwell
3 years, 9 months ago (2017-03-27 23:39:24 UTC) #3
dcheng
LGTM
3 years, 9 months ago (2017-03-28 01:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783463002/1
3 years, 9 months ago (2017-03-28 02:39:24 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 03:22:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e1e4faa96970748940416fc9068...

Powered by Google App Engine
This is Rietveld 408576698