Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2783433002: Gtk3: Use menubar instead of headerbar on version less than 3.10 (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Use menubar instead of headerbar on version less than 3.10 Headerbars were added in Gtk3.10. All officially supported Chromium distros meet this requirement, but this CL adds a check in case there are any users on odd distros without Gtk3.10. Specifically, a menubar is used instead of a headerbar in this case. In addition, this CL also changes the interface of several functions in gtk_util to use std::string instead of char*, so that I could use string concatenation in gtk_ui.cc. BUG=79722 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2783433002 Cr-Commit-Position: refs/heads/master@{#459934} Committed: https://chromium.googlesource.com/chromium/src/+/14e3acc30f4da1fe3f601828101af47eff68a828

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove bogus line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Tom (Use chromium acct)
erg ptal
3 years, 9 months ago (2017-03-27 22:26:44 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/2783433002/diff/1/chrome/browser/ui/libgtkui/gtk_ui.cc File chrome/browser/ui/libgtkui/gtk_ui.cc (right): https://codereview.chromium.org/2783433002/diff/1/chrome/browser/ui/libgtkui/gtk_ui.cc#newcode870 chrome/browser/ui/libgtkui/gtk_ui.cc:870: header_selector = "GtkMenuBar#menubar"; Is this a typo? You're setting ...
3 years, 9 months ago (2017-03-27 22:31:57 UTC) #4
Tom (Use chromium acct)
https://codereview.chromium.org/2783433002/diff/1/chrome/browser/ui/libgtkui/gtk_ui.cc File chrome/browser/ui/libgtkui/gtk_ui.cc (right): https://codereview.chromium.org/2783433002/diff/1/chrome/browser/ui/libgtkui/gtk_ui.cc#newcode870 chrome/browser/ui/libgtkui/gtk_ui.cc:870: header_selector = "GtkMenuBar#menubar"; On 2017/03/27 22:31:56, Elliot Glaysher wrote: ...
3 years, 9 months ago (2017-03-27 22:36:12 UTC) #5
Elliot Glaysher
lgtm
3 years, 9 months ago (2017-03-27 22:42:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783433002/20001
3 years, 9 months ago (2017-03-27 23:27:21 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 23:35:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/14e3acc30f4da1fe3f601828101a...

Powered by Google App Engine
This is Rietveld 408576698