Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2783423003:
Sync sqlite histograms.xml suffixes with code. (Closed)
|
Created:
3 years, 8 months ago by pasko Modified:
3 years, 8 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews, asvitkine+watch_chromium.org, Scott Hess - ex-Googler Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSync sqlite histograms.xml suffixes with code.
This allows seeing stats of the BackgroundRequestQueue sqlite database
on the UMA dashboard.
Also deprecates histograms that were removed from code.
BUG=697122
Review-Url: https://codereview.chromium.org/2783423003
Cr-Commit-Position: refs/heads/master@{#461395}
Committed: https://chromium.googlesource.com/chromium/src/+/6be2959e1a463d84b8d5c4cefa1b43dc0ede7cf1
Patch Set 1 #
Messages
Total messages: 23 (14 generated)
The CQ bit was checked by pasko@chromium.org to run a CQ dry run
Description was changed from ========== Sync sqlite histograms.xml suffixes with code. This allows seeing stats of the BackgroundRequestQueue sqlite database on the UMA dashboard. Also deprecates histograms that were removed from code. BUG=697122 ========== to ========== Sync sqlite histograms.xml suffixes with code. This allows seeing stats of the BackgroundRequestQueue sqlite database on the UMA dashboard. Also deprecates histograms that were removed from code. BUG=697122 ==========
pasko@chromium.org changed reviewers: + isherman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
isherman: I noticed other discrepancies for Sqlite.SizeKB, hopefully this fixes them all. shess: FYI
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by isherman@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by pasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by pasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
The CQ bit was checked by pasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491209152211580, "parent_rev":
"eaa64e91bb7bd27e7b1f001cd6ebba6a2c3f302f", "commit_rev":
"6be2959e1a463d84b8d5c4cefa1b43dc0ede7cf1"}
Message was sent while issue was closed.
Description was changed from ========== Sync sqlite histograms.xml suffixes with code. This allows seeing stats of the BackgroundRequestQueue sqlite database on the UMA dashboard. Also deprecates histograms that were removed from code. BUG=697122 ========== to ========== Sync sqlite histograms.xml suffixes with code. This allows seeing stats of the BackgroundRequestQueue sqlite database on the UMA dashboard. Also deprecates histograms that were removed from code. BUG=697122 Review-Url: https://codereview.chromium.org/2783423003 Cr-Commit-Position: refs/heads/master@{#461395} Committed: https://chromium.googlesource.com/chromium/src/+/6be2959e1a463d84b8d5c4cefa1b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6be2959e1a463d84b8d5c4cefa1b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
