Move //chrome/tools/mac_helpers:infoplist_strings_util to //chrome/tools/build/mac.

Move //chrome/tools/mac_helpers:infoplist_strings_util to //chrome/tools/build/mac.

NOPRESUBMIT=true
BUG=615107
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2783413002
Cr-Commit-Position: refs/heads/master@{#460982}
Committed: https://chromium.googlesource.com/chromium/src/+/0eef763fec7479bb937647bfd7e1659d916f38a6

[Robert Sesek, 2017-03-30 20:04:15]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 20:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-30 20:06:15]

lgtm

[Robert Sesek, 2017-03-30 20:10:28]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:10:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2017-03-30 20:12:55]

Description was changed from

==========
Move //chrome/tools/mac_helpers:infoplist_strings_util to
//chrome/tools/build/mac.

BUG=615107
R=thakis@chromium.org
==========

to

==========
Move //chrome/tools/mac_helpers:infoplist_strings_util to
//chrome/tools/build/mac.

NOPRESUBMIT=true (file move)
BUG=615107
R=thakis@chromium.org
==========

[Robert Sesek, 2017-03-30 20:17:42]

Description was changed from

==========
Move //chrome/tools/mac_helpers:infoplist_strings_util to
//chrome/tools/build/mac.

NOPRESUBMIT=true (file move)
BUG=615107
R=thakis@chromium.org
==========

to

==========
Move //chrome/tools/mac_helpers:infoplist_strings_util to
//chrome/tools/build/mac.

NOPRESUBMIT=true
BUG=615107
R=thakis@chromium.org
==========

[commit-bot: I haz the power, 2017-03-30 20:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:25:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-03-30 20:27:17]

** Presubmit Warnings **
The src directory requires source formatting. Please run git cl format .

** Presubmit ERRORS **
Banned functions were used.
    chrome/tools/build/mac/infoplist_strings_util.mm:40:
      The use of -[NSString UTF8String] is dangerous as it can return null
      even if |canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
      Please use |SysNSStringToUTF8| instead.
    chrome/tools/build/mac/infoplist_strings_util.mm:320:
      The use of -[NSString UTF8String] is dangerous as it can return null
      even if |canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
      Please use |SysNSStringToUTF8| instead.
    chrome/tools/build/mac/infoplist_strings_util.mm:330:
      The use of -[NSString UTF8String] is dangerous as it can return null
      even if |canBeConvertedToEncoding:NSUTF8StringEncoding| returns YES.
      Please use |SysNSStringToUTF8| instead.

Presubmit checks took 3.2s to calculate.

[Nico, 2017-03-30 20:27:34]

NOPRESUBMIT=true I suppose

[Robert Sesek, 2017-03-30 20:31:12]

On 2017/03/30 20:27:34, Nico (afk until Tue Apr 4) wrote:
> NOPRESUBMIT=true I suppose

I tried that but it seems to not be working. I guess I'll land directly?

[Robert Sesek, 2017-03-30 20:32:19]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2017-03-30 20:32:38]

On 2017/03/30 20:31:12, Robert Sesek wrote:
> On 2017/03/30 20:27:34, Nico (afk until Tue Apr 4) wrote:
> > NOPRESUBMIT=true I suppose
> 
> I tried that but it seems to not be working. I guess I'll land directly?

Oh, maybe the CQ just doesn't run chromium_presubmit in that case, rather than
the bot skipping the checks.

[commit-bot: I haz the power, 2017-03-30 20:34:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:50:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:50:22]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Robert Sesek, 2017-03-30 22:53:53]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:54:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 00:28:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490914433600640, "parent_rev":
"9a31be0e1cc31d7aba42d5131ce5621d589a07e6", "commit_rev":
"73391b27f50494d9474f30f6e785f59cb9ae9b1a"}

[commit-bot: I haz the power, 2017-03-31 01:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 01:30:42]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[Robert Sesek, 2017-03-31 01:30:59]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2017-03-31 01:31:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 01:37:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490923859822480, "parent_rev":
"4a22fdb230ae32c544d870cb55fbf3643a82adb9", "commit_rev":
"0eef763fec7479bb937647bfd7e1659d916f38a6"}

[commit-bot: I haz the power, 2017-03-31 01:38:27]

Description was changed from

==========
Move //chrome/tools/mac_helpers:infoplist_strings_util to
//chrome/tools/build/mac.

NOPRESUBMIT=true
BUG=615107
R=thakis@chromium.org
==========

to

==========
Move //chrome/tools/mac_helpers:infoplist_strings_util to
//chrome/tools/build/mac.

NOPRESUBMIT=true
BUG=615107
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2783413002
Cr-Commit-Position: refs/heads/master@{#460982}
Committed:
https://chromium.googlesource.com/chromium/src/+/0eef763fec7479bb937647bfd7e1...
==========

[commit-bot: I haz the power, 2017-03-31 01:38:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0eef763fec7479bb937647bfd7e1...