base/at_exit.cc - Issue 2783393002: Revert of Assert sequence validity on non-thread-safe RefCount manipulations (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/at_exit.cc

Issue 2783393002: Revert of Assert sequence validity on non-thread-safe RefCount manipulations (2) (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/at_exit.cc

diff --git a/base/at_exit.cc b/base/at_exit.cc

index e0025ea0d3b3dd96f821d8a624cd51aaee5d0a6b..5dcc83cb2f5c390ab8cdbc19ba601ec3fd01ab0b 100644

--- a/base/at_exit.cc

+++ b/base/at_exit.cc

@@ -81,10 +81,6 @@

g_top_manager->processing_callbacks_ = true;

}

- // Relax the cross-thread access restriction to non-thread-safe RefCount.

- // It's safe since all other threads should be terminated at this point.

- ScopedAllowCrossThreadRefCountAccess allow_cross_thread_ref_count_access;

while (!tasks.empty()) {

base::Closure task = tasks.top();

task.Run();

« no previous file with comments | « no previous file | base/memory/ref_counted.h » ('j') | no next file with comments »