chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc - Issue 2783343002: Remove URLRequestJobFactory::IsHandledURL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc

Issue 2783343002: Remove URLRequestJobFactory::IsHandledURL. (Closed)

Patch Set: More fixes..... Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/aw_url_request_job_factory.cc ('k') | chrome/browser/custom_handlers/protocol_handler_registry.h » ('j') | content/browser/download/download_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc

diff --git a/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc b/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc

index c5dc3b7378bd427c32ee7faee1262b3c46b20b90..058efbcff9169ff90520b11164ca07b17702f68f 100644

--- a/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc

+++ b/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc

@@ -83,10 +83,6 @@ class TestURLRequestJobFactory : public net::URLRequestJobFactory {

return scheme == content::kExternalFileScheme;

}

- bool IsHandledURL(const GURL& url) const override {

- return url.is_valid() && IsHandledProtocol(url.scheme());

- }

bool IsSafeRedirectTarget(const GURL& location) const override {

return true;

}