Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2783333002: Revert of Roll WebRTC 17451:17473 (17 commits) (Closed)

Created:
3 years, 8 months ago by stgao
Modified:
3 years, 8 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll WebRTC 17451:17473 (17 commits) (patchset #1 id:1 of https://codereview.chromium.org/2788633002/ ) Reason for revert: This failed RenderWidgetHostViewChildFrameTest.ForwardsBeginFrameAcks on Waterfall Windows bots. It is hard to tell by reading the crash and the change here, but the test failed 100% on 800 reruns, and the tryjob showed the test failed begging with this CL. Will reland if this won't work. https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzIyNDAwL2NvbnRlbnRfdW5pdHRlc3RzL1VtVnVaR1Z5VjJsa1oyVjBTRzl6ZEZacFpYZERhR2xzWkVaeVlXMWxWR1Z6ZEM1R2IzSjNZWEprYzBKbFoybHVSbkpoYldWQlkydHoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/22400 Original issue's description: > Roll WebRTC 17451:17473 (17 commits) > > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8f121b8..246a8f4 > > $ git log 8f121b8..246a8f4 --date=short --no-merges --format=%ad %ae %s > 2017-03-30 philipel@webrtc.org Reduce flakiness in EndToEnd probing tests. > 2017-03-30 kthelgason@webrtc.org Fix deprecated methods in AppRTCMobile. > 2017-03-30 aleloi@webrtc.org Disable flaky test EndToEndTest.TriggerMidCallProbing > 2017-03-30 oprypin@webrtc.org Add Windows, Mac, Android support to low bandwidth audio test > 2017-03-30 mbonadei@webrtc.org To accommodate some downstream WebRTC users we need to loosen the coupling between our code and the //third_party/protobuf. > 2017-03-30 kthelgason@webrtc.org Remove more CriticalSectionWrappers. > 2017-03-30 magjed@webrtc.org Fix JNI reference leak in MediaCodecVideoDecoder > 2017-03-30 kthelgason@webrtc.org Synchronize task queue operations in QualityScaler tests. > 2017-03-30 stefan@webrtc.org Add back sender_time and receiver_time metrics to full stack tests. > 2017-03-30 henrika@webrtc.org Avoid calling AudioEffect.queryEffects to avoid potential crash. > 2017-03-30 nisse@webrtc.org Delete unneeded includes of deprecated system_wrappers include files. > 2017-03-29 nisse@webrtc.org Reland of Don't hardcode MediaType::ANY in FakeNetworkPipe. (patchset #1 id:1 of https://codereview.webrtc.org/2784543002/ ) > 2017-03-29 deadbeef@webrtc.org Rewrite PeerConnection integration tests using better testing practices. > 2017-03-29 haysc@webrtc.org Add logging around audio session interruptions. Always treat returning to foreground as interruption ended event, to help fix out of sync issues with interruption state. > 2017-03-29 zijiehe@chromium.org ScreenCapturerWinDirectx may flicker on certain hardware > 2017-03-29 elad.alon@webrtc.org Add documentation to the ThresholdCurve unit tests > 2017-03-29 sprang@webrtc.org Use simulcast for screenshare only in conference mode > > TBR= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > BUG= > > Review-Url: https://codereview.chromium.org/2788633002 > Cr-Commit-Position: refs/heads/master@{#460761} > Committed: https://chromium.googlesource.com/chromium/src/+/7c23442327b2fbc905a595bb62e76e03dc01025d TBR=hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2783333002 Cr-Commit-Position: refs/heads/master@{#460834} Committed: https://chromium.googlesource.com/chromium/src/+/d22af31b5bf873a9ad1d7fcd59210df08ea33a89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
stgao
Created Revert of Roll WebRTC 17451:17473 (17 commits)
3 years, 8 months ago (2017-03-30 18:38:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783333002/1
3 years, 8 months ago (2017-03-30 18:38:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d22af31b5bf873a9ad1d7fcd59210df08ea33a89
3 years, 8 months ago (2017-03-30 18:40:28 UTC) #6
stgao
3 years, 8 months ago (2017-03-30 19:31:41 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2783383002/ by stgao@chromium.org.

The reason for reverting is: The revert doesn't help.

https://luci-milo.appspot.com/buildbot/chromium.win/Win%207%20Tests%20x64%20%....

Powered by Google App Engine
This is Rietveld 408576698