Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2783293002: Update build/linux/unbundle/README (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update build/linux/unbundle/README - Better explain what this component does. - Add a detailed description for replace_gn_files.py. - Format text to fit in 72 columns. - Mention GN build files. Review-Url: https://codereview.chromium.org/2783293002 Cr-Commit-Position: refs/heads/master@{#461186} Committed: https://chromium.googlesource.com/chromium/src/+/5864d312aa006009fb4734c59320f04f2d6dceb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M build/linux/unbundle/README View 3 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
3 years, 8 months ago (2017-03-30 17:46:20 UTC) #2
Paweł Hajdan Jr.
LGTM Thanks! :)
3 years, 8 months ago (2017-03-31 09:35:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783293002/1
3 years, 8 months ago (2017-03-31 19:16:46 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 19:45:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5864d312aa006009fb4734c59320...

Powered by Google App Engine
This is Rietveld 408576698