Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2783253002: Avoid duplicating the target name "svg". (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
pdr., fs
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, rwlbuis, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, fmalita+watch_chromium.org, fs, krit, jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicating the target name "svg". It has not been possible to build just the svg code with ninja -C out/Default svg because of two other, minor, build targets named svg. This commit renames those svg_layout and svg_style. Review-Url: https://codereview.chromium.org/2783253002 Cr-Commit-Position: refs/heads/master@{#461073} Committed: https://chromium.googlesource.com/chromium/src/+/e4218f89ae50b22efd8c98b97f57fa138a4dfe19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Daniel Bratell
PTAL
3 years, 8 months ago (2017-03-30 16:11:12 UTC) #4
pdr.
On 2017/03/30 at 16:11:12, bratell wrote: > PTAL LGTM if it works. Can you explain ...
3 years, 8 months ago (2017-03-30 17:50:49 UTC) #5
Daniel Bratell
On 2017/03/30 17:50:49, pdr. wrote: > On 2017/03/30 at 16:11:12, bratell wrote: > > PTAL ...
3 years, 8 months ago (2017-03-31 07:51:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783253002/1
3 years, 8 months ago (2017-03-31 07:51:58 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 07:57:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4218f89ae50b22efd8c98b97f57...

Powered by Google App Engine
This is Rietveld 408576698