Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2783243002: Rename s_range to avoid conflicts with Blink rewrite. (Closed)

Created:
3 years, 8 months ago by nasko
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename s_range to avoid conflicts with Blink rewrite. When the Blink rewrite tool runs to convert the code to Chromium style, the m_range and s_range mebers get rewritten to the same variable, causing conflicts. This CL renames the static member to avoid such collision. BUG= Review-Url: https://codereview.chromium.org/2783243002 Cr-Commit-Position: refs/heads/master@{#460969} Committed: https://chromium.googlesource.com/chromium/src/+/76554ae5a13a9e78a12c4782287319820d270c15

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address dcheng@'s feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/Range.cpp View 1 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
nasko
Hey Daniel, Can you review this CL for me? Thanks in advance! Nasko
3 years, 8 months ago (2017-03-30 15:57:23 UTC) #4
dcheng
https://codereview.chromium.org/2783243002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2783243002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp#newcode65 third_party/WebKit/Source/core/dom/Range.cpp:65: RangeUpdateScope(Range* range) { Mind fixing this to add explicit ...
3 years, 8 months ago (2017-03-30 18:46:31 UTC) #7
nasko
https://codereview.chromium.org/2783243002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2783243002/diff/1/third_party/WebKit/Source/core/dom/Range.cpp#newcode65 third_party/WebKit/Source/core/dom/Range.cpp:65: RangeUpdateScope(Range* range) { On 2017/03/30 18:46:31, dcheng wrote: > ...
3 years, 8 months ago (2017-03-30 22:59:20 UTC) #8
dcheng
lgtm
3 years, 8 months ago (2017-03-31 00:57:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783243002/20001
3 years, 8 months ago (2017-03-31 00:57:48 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:09:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76554ae5a13a9e78a12c47822873...

Powered by Google App Engine
This is Rietveld 408576698