Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2783233004: Refine tap disambiguation UMA to track same-node/different-node. (Closed)
Patch Set: Deprecate existing field Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 84125df7bd71fc340acfb806624a14f9c8927378..acc6ea41610eb7bfa384edc1ad4c3ba3e5368d6d 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -429,6 +429,10 @@ class WEB_EXPORT WebViewImpl final
void animateDoubleTapZoom(const IntPoint&);
+ void resolveTapDisambiguation(double timestampSeconds,
+ WebPoint tapViewportOffset,
+ bool isLongPress) override;
+
void enableFakePageScaleAnimationForTesting(bool);
bool fakeDoubleTapAnimationPendingForTesting() const {
return m_doubleTapZoomPending;
@@ -708,6 +712,8 @@ class WEB_EXPORT WebViewImpl final
std::unique_ptr<CompositorAnimationTimeline> m_linkHighlightsTimeline;
std::unique_ptr<FullscreenController> m_fullscreenController;
+ WebPoint m_lastTapDisambiguationBestCandidatePosition;
+
WebColor m_baseBackgroundColor;
bool m_baseBackgroundColorOverrideEnabled;
WebColor m_baseBackgroundColorOverride;
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698