Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2783233004: Refine tap disambiguation UMA to track same-node/different-node. (Closed)
Patch Set: Deprecate existing field Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 const GestureEventWithHitTestResults& targetedTapEvent); 422 const GestureEventWithHitTestResults& targetedTapEvent);
423 void enableTapHighlights(HeapVector<Member<Node>>&); 423 void enableTapHighlights(HeapVector<Member<Node>>&);
424 void computeScaleAndScrollForFocusedNode(Node* focusedNode, 424 void computeScaleAndScrollForFocusedNode(Node* focusedNode,
425 bool zoomInToLegibleScale, 425 bool zoomInToLegibleScale,
426 float& scale, 426 float& scale,
427 IntPoint& scroll, 427 IntPoint& scroll,
428 bool& needAnimation); 428 bool& needAnimation);
429 429
430 void animateDoubleTapZoom(const IntPoint&); 430 void animateDoubleTapZoom(const IntPoint&);
431 431
432 void resolveTapDisambiguation(double timestampSeconds,
433 WebPoint tapViewportOffset,
434 bool isLongPress) override;
435
432 void enableFakePageScaleAnimationForTesting(bool); 436 void enableFakePageScaleAnimationForTesting(bool);
433 bool fakeDoubleTapAnimationPendingForTesting() const { 437 bool fakeDoubleTapAnimationPendingForTesting() const {
434 return m_doubleTapZoomPending; 438 return m_doubleTapZoomPending;
435 } 439 }
436 IntPoint fakePageScaleAnimationTargetPositionForTesting() const { 440 IntPoint fakePageScaleAnimationTargetPositionForTesting() const {
437 return m_fakePageScaleAnimationTargetPosition; 441 return m_fakePageScaleAnimationTargetPosition;
438 } 442 }
439 float fakePageScaleAnimationPageScaleForTesting() const { 443 float fakePageScaleAnimationPageScaleForTesting() const {
440 return m_fakePageScaleAnimationPageScaleFactor; 444 return m_fakePageScaleAnimationPageScaleFactor;
441 } 445 }
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 MediaKeysClientImpl m_mediaKeysClientImpl; 705 MediaKeysClientImpl m_mediaKeysClientImpl;
702 std::unique_ptr<WebActiveGestureAnimation> m_gestureAnimation; 706 std::unique_ptr<WebActiveGestureAnimation> m_gestureAnimation;
703 WebPoint m_positionOnFlingStart; 707 WebPoint m_positionOnFlingStart;
704 WebPoint m_globalPositionOnFlingStart; 708 WebPoint m_globalPositionOnFlingStart;
705 int m_flingModifier; 709 int m_flingModifier;
706 WebGestureDevice m_flingSourceDevice; 710 WebGestureDevice m_flingSourceDevice;
707 Vector<std::unique_ptr<LinkHighlightImpl>> m_linkHighlights; 711 Vector<std::unique_ptr<LinkHighlightImpl>> m_linkHighlights;
708 std::unique_ptr<CompositorAnimationTimeline> m_linkHighlightsTimeline; 712 std::unique_ptr<CompositorAnimationTimeline> m_linkHighlightsTimeline;
709 std::unique_ptr<FullscreenController> m_fullscreenController; 713 std::unique_ptr<FullscreenController> m_fullscreenController;
710 714
715 WebPoint m_lastTapDisambiguationBestCandidatePosition;
716
711 WebColor m_baseBackgroundColor; 717 WebColor m_baseBackgroundColor;
712 bool m_baseBackgroundColorOverrideEnabled; 718 bool m_baseBackgroundColorOverrideEnabled;
713 WebColor m_baseBackgroundColorOverride; 719 WebColor m_baseBackgroundColorOverride;
714 WebColor m_backgroundColorOverride; 720 WebColor m_backgroundColorOverride;
715 float m_zoomFactorOverride; 721 float m_zoomFactorOverride;
716 722
717 bool m_userGestureObserved; 723 bool m_userGestureObserved;
718 bool m_shouldDispatchFirstVisuallyNonEmptyLayout; 724 bool m_shouldDispatchFirstVisuallyNonEmptyLayout;
719 bool m_shouldDispatchFirstLayoutAfterFinishedParsing; 725 bool m_shouldDispatchFirstLayoutAfterFinishedParsing;
720 bool m_shouldDispatchFirstLayoutAfterFinishedLoading; 726 bool m_shouldDispatchFirstLayoutAfterFinishedLoading;
(...skipping 23 matching lines...) Expand all
744 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor; 750 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor;
745 }; 751 };
746 752
747 // We have no ways to check if the specified WebView is an instance of 753 // We have no ways to check if the specified WebView is an instance of
748 // WebViewImpl because WebViewImpl is the only implementation of WebView. 754 // WebViewImpl because WebViewImpl is the only implementation of WebView.
749 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 755 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
750 756
751 } // namespace blink 757 } // namespace blink
752 758
753 #endif 759 #endif
OLDNEW
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698