Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2783203005: [perf-prof] Adjust source position addresses according to ELF header size (Closed)

Created:
3 years, 8 months ago by Pierre Langlois
Modified:
3 years, 8 months ago
Reviewers:
Jarin, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[perf-prof] Adjust source position addresses according to ELF header size The "perf inject" command will place the generated function into a .text section, placed directly after the ELF header. As a result, source position addresses need to be adjusted according to the size of the ELF header, which is 0x40 for 64 bit architectures and 0x34 on 32 bit architectures. We would previously adjust the addresses with 0x40 regardless of the architecture. BUG= Review-Url: https://codereview.chromium.org/2783203005 Cr-Commit-Position: refs/heads/master@{#44325} Committed: https://chromium.googlesource.com/v8/v8/+/3258b2690e1be50e2ab47722585ecfc29754a657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/perf-jit.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/perf-jit.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Pierre Langlois
3 years, 8 months ago (2017-03-31 15:01:24 UTC) #3
Jarin
lgtm. Thanks!
3 years, 8 months ago (2017-04-03 06:55:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783203005/1
3 years, 8 months ago (2017-04-03 07:51:27 UTC) #6
danno
lgtm. Thanks for spending the time to figure this all out!
3 years, 8 months ago (2017-04-03 08:00:54 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 08:15:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3258b2690e1be50e2ab47722585ecfc2975...

Powered by Google App Engine
This is Rietveld 408576698