Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2783203004: Correctly destroy returned front buffer after resize (Closed)

Created:
3 years, 8 months ago by piman
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Correctly destroy returned front buffer after resize When returning a front buffer with ReturnFrontBuffer, if the front buffer was resized in the mean time, we were considering the returned mailbox as lost, and never freeing it, causing a large GPU memory leak. This patch fixes it. BUG=692074 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2779873002 Cr-Commit-Position: refs/heads/master@{#459969} (cherry picked from commit 15176a8d134862de21fe2de9f9fd1d7390ac9003) Review-Url: https://codereview.chromium.org/2783203004 . Cr-Commit-Position: refs/branch-heads/3029@{#495} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/49aa6162abfe9749ead405c8f593abdea54ad630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
piman
3 years, 8 months ago (2017-03-30 18:57:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49aa6162abfe9749ead405c8f593abdea54ad630.

Powered by Google App Engine
This is Rietveld 408576698