Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2783173004: Fix broken ios_chrome_web_egtests. (Closed)

Created:
3 years, 8 months ago by michaeldo
Modified:
3 years, 8 months ago
Reviewers:
baxley, jif
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken ios_chrome_web_egtests. Relax the cross-thread access restriction to non-thread-safe RefCount inside test HttpServer. New DCHECK failure is caused by https://codereview.chromium.org/2666423002. BUG=none Review-Url: https://codereview.chromium.org/2783173004 Cr-Commit-Position: refs/heads/master@{#461428} Committed: https://chromium.googlesource.com/chromium/src/+/8d8ab2fcd255b0e16c5435cf27ddd1fe50acb83c

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Add missing include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M ios/web/public/test/http_server.mm View 1 2 6 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
michaeldo
3 years, 8 months ago (2017-03-30 21:20:54 UTC) #2
baxley
lgtm
3 years, 8 months ago (2017-03-30 21:22:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783173004/20001
3 years, 8 months ago (2017-03-30 21:24:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/181113)
3 years, 8 months ago (2017-03-30 21:50:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783173004/40001
3 years, 8 months ago (2017-03-30 21:58:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/181145) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-03-30 22:08:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783173004/40001
3 years, 8 months ago (2017-04-03 14:32:37 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 14:44:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8d8ab2fcd255b0e16c5435cf27dd...

Powered by Google App Engine
This is Rietveld 408576698