Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2783143004: Move QuicStreamFactoryPeer from net/quic/test_tools/ to net/quic/chromium/ (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Buck
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move QuicStreamFactoryPeer from net/quic/test_tools/ to net/quic/chromium/ BUG= Review-Url: https://codereview.chromium.org/2783143004 Cr-Commit-Position: refs/heads/master@{#461540} Committed: https://chromium.googlesource.com/chromium/src/+/99387f9bddb4ad0a02bcc29a97ffd571ec749708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -329 lines) Patch
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/quic/chromium/quic_stream_factory_peer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/quic/chromium/quic_stream_factory_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 2 chunks +1 line, -1 line 0 comments Download
D net/quic/test_tools/quic_stream_factory_peer.h View 1 chunk +0 lines, -113 lines 0 comments Download
D net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +0 lines, -207 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ryan Hamilton
3 years, 8 months ago (2017-03-31 19:58:56 UTC) #2
Buck
lgtm
3 years, 8 months ago (2017-04-03 17:51:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783143004/1
3 years, 8 months ago (2017-04-03 17:52:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/185805)
3 years, 8 months ago (2017-04-03 18:58:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783143004/1
3 years, 8 months ago (2017-04-03 19:56:52 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 21:13:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99387f9bddb4ad0a02bcc29a97ff...

Powered by Google App Engine
This is Rietveld 408576698