Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2783143002: Rename reason to message in csd.proto (Closed)

Created:
3 years, 8 months ago by Joe Mason
Modified:
3 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename reason to message in csd.proto, to match a server-side change. This does _not_ change the tag number, so the proto is still wire-compatible, so there are no compatibility concerns. BUG=708583 Review-Url: https://codereview.chromium.org/2783143002 Cr-Commit-Position: refs/heads/master@{#462219} Committed: https://chromium.googlesource.com/chromium/src/+/dee02108c6c8a064f04bbbb214c07c60cb48f48c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/safe_browsing/csd.proto View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Joe Mason
PTAL.
3 years, 8 months ago (2017-04-05 15:01:40 UTC) #7
Jialiu Lin
lgtm
3 years, 8 months ago (2017-04-05 20:12:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783143002/1
3 years, 8 months ago (2017-04-05 20:14:21 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 21:22:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dee02108c6c8a064f04bbbb214c0...

Powered by Google App Engine
This is Rietveld 408576698