Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2783113002: nit: Pass ownership of CVDelegate to ContentVerifier using unique_ptr. (Closed)

Created:
3 years, 8 months ago by lazyboy
Modified:
3 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

nit: Pass ownership of CVDelegate to ContentVerifier using unique_ptr. BUG=None Test=None, cleanup. Review-Url: https://codereview.chromium.org/2783113002 Cr-Commit-Position: refs/heads/master@{#460812} Committed: https://chromium.googlesource.com/chromium/src/+/528dedac25dfabbba42563f5a3039c43864f604b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_verifier.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/content_verifier.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
lazyboy
3 years, 8 months ago (2017-03-30 15:40:39 UTC) #7
Devlin
lgtm
3 years, 8 months ago (2017-03-30 16:24:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783113002/1
3 years, 8 months ago (2017-03-30 17:25:52 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 17:34:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/528dedac25dfabbba42563f5a303...

Powered by Google App Engine
This is Rietveld 408576698