[MD settings] done button in passwords dialog as action button

[MD settings] done button in passwords dialog as action button

This CL makes the Done button in the passwords dialog an action button,
rather than a cancel button. This positions and styles the button as
desired. This CL also accepts the Enter key to close the dialog.

BUG=706643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2783063002
Cr-Commit-Position: refs/heads/master@{#460831}
Committed: https://chromium.googlesource.com/chromium/src/+/e6a2ed91fb2df3c4f234ca8824cfb570f902897c

[dschuyler, 2017-03-30 00:37:04]

Description was changed from

==========
[MD settings] done button in passwords dialog as action button

This CL makes the Done button in the passwords dialog an action button,
rather than a cancel button. This positions and styles the button as
desired. This CL also accepts the Enter key to close the dialog.

BUG=706643
==========

to

==========
[MD settings] done button in passwords dialog as action button

This CL makes the Done button in the passwords dialog an action button,
rather than a cancel button. This positions and styles the button as
desired. This CL also accepts the Enter key to close the dialog.

BUG=706643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-30 00:37:06]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 00:38:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-30 00:39:16]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:09:05]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2017-03-30 16:35:03]

lgtm

https://codereview.chromium.org/2783063002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
(left):

https://codereview.chromium.org/2783063002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js:96:
onSaveButtonTap_: function() {
Thanks for removing dead code :-)

[dschuyler, 2017-03-30 18:11:31]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-03-30 18:12:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 18:28:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490897491068230, "parent_rev":
"75d1fbdea6f82d547d7eec45d659ab5491f24e7a", "commit_rev":
"e6a2ed91fb2df3c4f234ca8824cfb570f902897c"}

[commit-bot: I haz the power, 2017-03-30 18:28:49]

Description was changed from

==========
[MD settings] done button in passwords dialog as action button

This CL makes the Done button in the passwords dialog an action button,
rather than a cancel button. This positions and styles the button as
desired. This CL also accepts the Enter key to close the dialog.

BUG=706643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] done button in passwords dialog as action button

This CL makes the Done button in the passwords dialog an action button,
rather than a cancel button. This positions and styles the button as
desired. This CL also accepts the Enter key to close the dialog.

BUG=706643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2783063002
Cr-Commit-Position: refs/heads/master@{#460831}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6a2ed91fb2df3c4f234ca8824cf...
==========

[commit-bot: I haz the power, 2017-03-30 18:28:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6a2ed91fb2df3c4f234ca8824cf...