Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2783043002: PPC/s390: [cleanup] combine 3 ResumeGenerator stubs into one (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [cleanup] combine 3 ResumeGenerator stubs into one Port 5615e5b86609362a84ef3c213e6e901a6f8c6637 Original Commit Message: This hopefully shrinks binary size a bit, at the cost of (slightly) increasing the complexity of the ResumeGenerator stub. Includes ia32, x64, mips, mips64, arm and arm64 ports. R=caitp@igalia.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5855 LOG=N Review-Url: https://codereview.chromium.org/2783043002 Cr-Commit-Position: refs/heads/master@{#44253} Committed: https://chromium.googlesource.com/v8/v8/+/411efc16a7a0fc8c01294c64587625fd8dad9a67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -100 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +26 lines, -26 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +26 lines, -26 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +27 lines, -21 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +27 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 8 months ago (2017-03-29 21:52:48 UTC) #1
john.yan
lgtm
3 years, 8 months ago (2017-03-29 21:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783043002/1
3 years, 8 months ago (2017-03-29 21:56:13 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:18:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/411efc16a7a0fc8c01294c64587625fd8da...

Powered by Google App Engine
This is Rietveld 408576698