Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2783013002: Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (Closed)

Created:
3 years, 8 months ago by BigBossZhiling
Modified:
3 years, 8 months ago
Reviewers:
qiangchen, DaleCurtis
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable (patchset #3 id:60001 of https://codereview.chromium.org/2751353003/ ) Reason for revert: Reverting the cl to see whether lock contention has increased chrome public test apk time. Thanks qiangchen for understanding! Original issue's description: > Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable > > On thread sanitizer, we found a data race issue for WebMediaPlayerMS' frame > count variables |total_frame_count_| and |dropped_frame_count_|. In this CL > We make those two variables atomic. > > BUG=701712 > > Review-Url: https://codereview.chromium.org/2751353003 > Cr-Commit-Position: refs/heads/master@{#457786} > Committed: https://chromium.googlesource.com/chromium/src/+/4cb6dcab2e3d9b4f14ff3bd5dc8f3fd3a57e19e5 TBR=dalecurtis@chromium.org,qiangchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M content/renderer/media/webmediaplayer_ms_compositor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
BigBossZhiling
Created Revert of Bug Fix: Data Race For WebMediaPlayerMS' Frame Count Variable
3 years, 8 months ago (2017-03-29 21:02:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783013002/1
3 years, 8 months ago (2017-03-29 21:03:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-29 21:03:46 UTC) #5
qiangchen
On 2017/03/29 21:03:46, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 8 months ago (2017-03-29 21:10:12 UTC) #6
chromium-reviews
3 years, 8 months ago (2017-03-29 21:13:09 UTC) #7
Message was sent while issue was closed.
Nice!

On Wed, Mar 29, 2017 at 2:10 PM, <qiangchen@chromium.org> wrote:

> On 2017/03/29 21:03:46, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet.
> > CQ run can only be started once the patch has received an L-G-T-M from a
> full
> > committer.
> > Even if an L-G-T-M may have been provided, it was from a
> non-committer,_not_ a
> > full super star committer.
> > Committers are members of the group "project-chromium-committers".
> > Note that this has nothing to do with OWNERS files.
>
> I've created a revert CL, and it is in CQ now, so you can close this one.
>
> https://codereview.chromium.org/2783013002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698