Better handling of stepping out of a function...

Better handling of stepping out of a function

With the change in r4820 all return statements are now breakable like any statement, so stepping will stop before the return statement actually returning from a function. With this change the position when breaking in the function return (after executing the return statement) will be the actual end of the function. At this point the return value is available as it saved to the stack by the debug break at return handling. Added information on the actual value returned from the function to the debugger.

Committed: http://code.google.com/p/v8/source/detail?r=4835

[yurys, 2010-06-09 13:47:55]

LGTM

http://codereview.chromium.org/2783002/diff/8001/9009
File src/runtime.cc (right):

http://codereview.chromium.org/2783002/diff/8001/9009#newcode8358
src/runtime.cc:8358: // value to return on top. A debug break at return will
creates an
typo: will creates -> will create

[Mads Ager (chromium), 2010-06-09 15:26:30]

LGTM!

http://codereview.chromium.org/2783002/diff/8001/9009
File src/runtime.cc (right):

http://codereview.chromium.org/2783002/diff/8001/9009#newcode8349
src/runtime.cc:8349: StackFrameIterator it2;
it2 -> it?

http://codereview.chromium.org/2783002/diff/8001/9011
File test/mjsunit/debug-return-value.js (right):

http://codereview.chromium.org/2783002/diff/8001/9011#newcode1
test/mjsunit/debug-return-value.js:1: // Copyright 2008 the V8 project authors.
All rights reserved.
2010

[Søren Thygesen Gjesse, 2010-06-10 07:23:03]

http://codereview.chromium.org/2783002/diff/8001/9009
File src/runtime.cc (right):

http://codereview.chromium.org/2783002/diff/8001/9009#newcode8349
src/runtime.cc:8349: StackFrameIterator it2;
On 2010/06/09 15:26:31, Mads Ager wrote:
> it2 -> it?

This is to avoid confusing it with the JavaScriptFrameIterator named it in the
outer scope.

http://codereview.chromium.org/2783002/diff/8001/9009#newcode8358
src/runtime.cc:8358: // value to return on top. A debug break at return will
creates an
On 2010/06/09 13:47:55, Yury Semikhatsky wrote:
> typo: will creates -> will create

Done.

http://codereview.chromium.org/2783002/diff/8001/9011
File test/mjsunit/debug-return-value.js (right):

http://codereview.chromium.org/2783002/diff/8001/9011#newcode1
test/mjsunit/debug-return-value.js:1: // Copyright 2008 the V8 project authors.
All rights reserved.
On 2010/06/09 15:26:31, Mads Ager wrote:
> 2010

Done.