Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 2782973002: Recommend noexcept for move constructors. (Closed)

Created:
3 years, 8 months ago by brettw
Modified:
3 years, 8 months ago
Reviewers:
danakj, jbroman
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Recommend noexcept for move constructors. Marking move constructors "noexcept" allows std::vector to use the move constructors in container resizes. Otherwise it will copy which is not expected by most callers. http://en.cppreference.com/w/cpp/language/move_constructor This also replaces some technically invalid characters with HTML entities. Discussion: https://groups.google.com/a/chromium.org/d/msg/cxx/ze4WJFg7RvU/Qhbb6DTrBQAJ Review-Url: https://codereview.chromium.org/2782973002 Cr-Commit-Position: refs/heads/master@{#460530} Committed: https://chromium.googlesource.com/chromium/src/+/9efba0cd0d357c433d878635e673d5de4a2f4be1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M styleguide/c++/c++11.html View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jbroman
This lgtm. Agreed that explicitly calling out why move constructors but not move assignment operators ...
3 years, 8 months ago (2017-03-29 19:41:32 UTC) #3
danakj
LGTM too
3 years, 8 months ago (2017-03-29 19:45:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782973002/1
3 years, 8 months ago (2017-03-29 19:55:04 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:50:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9efba0cd0d357c433d878635e673...

Powered by Google App Engine
This is Rietveld 408576698