Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2782963002: Revert of Make VR screen tap tests more stable (Closed)

Created:
3 years, 8 months ago by mdjones
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make VR screen tap tests more stable (patchset #6 id:100001 of https://codereview.chromium.org/2768583002/ ) Reason for revert: Breaking compile on several bots including Android x64 builder: symbol: class OnDispatchTouchEventCallback location: class WebVrTest ../../chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java:269: error: cannot find symbol ((VrShellImpl) VrShellDelegate.getVrShellForTesting() Original issue's description: > Make VR screen tap tests more stable > > The single tap sent during the VR screen tap tests wasn't always > getting registered since device response can be a bit slow during > the VR transition. For the Cardboard case, wait on Javascript to say > it received another click event. For the Daydream case, wait on VrShell > saying its parent has consumed the event before checking. > BUG= > > Review-Url: https://codereview.chromium.org/2768583002 > Cr-Commit-Position: refs/heads/master@{#460452} > Committed: https://chromium.googlesource.com/chromium/src/+/3e2ce51e88f19f0cc5196284f580583ddd4dbd9a TBR=dtrainor@chromium.org,tedchoc@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2782963002 Cr-Commit-Position: refs/heads/master@{#460490} Committed: https://chromium.googlesource.com/chromium/src/+/12d7fecd789f8d242a3e8d1c71446d553e67b3e3

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
mdjones
Created Revert of Make VR screen tap tests more stable
3 years, 8 months ago (2017-03-29 19:20:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782963002/1
3 years, 8 months ago (2017-03-29 19:21:30 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:31:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12d7fecd789f8d242a3e8d1c7144...

Powered by Google App Engine
This is Rietveld 408576698