Disable sending persistent histograms from last session by default.

Disable sending persistent histograms from last session by default.

Moves the logic to a different location than before so that it only
affects upload of persistent histograms data and not other .pma
file metrics - like crashpad and installer.

BUG=706423
Review-Url: https://codereview.chromium.org/2782903002
Cr-Commit-Position: refs/heads/master@{#460465}
Committed: https://chromium.googlesource.com/chromium/src/+/c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e

[Alexei Svitkine (slow), 2017-03-29 15:52:38]

asvitkine@chromium.org changed reviewers:
+ bcwhite@chromium.org

[bcwhite, 2017-03-29 16:09:12]

lgtm

https://codereview.chromium.org/2782903002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/2782903002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_metrics_service_client.cc:218: boolean
report_previous_persistent_histograms =
boolean => bool

[Alexei Svitkine (slow), 2017-03-29 16:17:17]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:18:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-03-29 16:19:02]

https://codereview.chromium.org/2782903002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/2782903002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_metrics_service_client.cc:218: boolean
report_previous_persistent_histograms =
On 2017/03/29 16:09:12, bcwhite wrote:
> boolean => bool

Oops, teaches for sending right before lunch before having a chance to compile.
Done.

[Alexei Svitkine (slow), 2017-03-29 16:22:05]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 16:34:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:34:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alexei Svitkine (slow), 2017-03-29 16:50:35]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:51:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-03-29 17:17:45]

The CQ bit was unchecked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-03-29 17:17:49]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-03-29 17:17:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org
Link to the patchset: https://codereview.chromium.org/2782903002/#ps40001
(title: "Fix includes and use base/ param API.")

[commit-bot: I haz the power, 2017-03-29 17:18:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:30:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490807869898710,
"parent_rev": "e70e89bec8b805f1056ba85e1e14c9486341d138", "commit_rev":
"c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e"}

[commit-bot: I haz the power, 2017-03-29 18:31:52]

Description was changed from

==========
Disable sending persistent histograms from last session by default.

Moves the logic to a different location than before so that it only
affects upload of persistent histograms data and not other .pma
file metrics - like crashpad and installer.

BUG=706423
==========

to

==========
Disable sending persistent histograms from last session by default.

Moves the logic to a different location than before so that it only
affects upload of persistent histograms data and not other .pma
file metrics - like crashpad and installer.

BUG=706423

Review-Url: https://codereview.chromium.org/2782903002
Cr-Commit-Position: refs/heads/master@{#460465}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8cf9f23a6c3b6d69e9528d7e9a4...
==========

[commit-bot: I haz the power, 2017-03-29 18:31:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c8cf9f23a6c3b6d69e9528d7e9a4...