third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

index 0ba7564508a0dafcbca0fa5fde2be4a1fd4a3f6a..2b86e5ce8ed0224d2b1e9556b0c46edcd3eadbc6 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

@@ -543,8 +543,7 @@ void WebDevToolsAgentImpl::inspectElementAt(int sessionId,

HitTestRequest request(hitType);

WebMouseEvent dummyEvent(WebInputEvent::MouseDown, WebInputEvent::NoModifiers,

WTF::monotonicallyIncreasingTimeMS());

- dummyEvent.x = pointInRootFrame.x;

- dummyEvent.y = pointInRootFrame.y;

+ dummyEvent.setPositionInWidget(pointInRootFrame.x, pointInRootFrame.y);

IntPoint transformedPoint = flooredIntPoint(

TransformWebMouseEvent(m_webLocalFrameImpl->frameView(), dummyEvent)

.positionInRootFrame());