Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/public/platform/WebMouseEvent.h

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Fixed compile failures. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | ui/events/blink/blink_event_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMouseEvent.h
diff --git a/third_party/WebKit/public/platform/WebMouseEvent.h b/third_party/WebKit/public/platform/WebMouseEvent.h
index fee8a2572fe5cd5faf5746d128e2b097a15ad115..4602ade567425562c03636ebef821793c36126fc 100644
--- a/third_party/WebKit/public/platform/WebMouseEvent.h
+++ b/third_party/WebKit/public/platform/WebMouseEvent.h
@@ -21,12 +21,10 @@ class WebMouseEvent : public WebInputEvent, public WebPointerProperties {
// Renderer coordinates. Similar to viewport coordinates but without
// DevTools emulation transform or overscroll applied. i.e. the coordinates
// in Chromium's RenderView bounds.
- int x;
- int y;
+ WebFloatPoint position;
dtapuska 2017/03/29 20:19:15 I think we really should move these to be accessor
mustaq 2017/03/30 21:01:35 Done, all done, phew!
// Screen coordinate
- int globalX;
- int globalY;
+ WebFloatPoint screenPosition;
int clickCount;
@@ -42,10 +40,8 @@ class WebMouseEvent : public WebInputEvent, public WebPointerProperties {
modifiersParam,
timeStampSecondsParam),
WebPointerProperties(),
- x(xParam),
- y(yParam),
- globalX(globalXParam),
- globalY(globalYParam) {}
+ position(xParam, yParam),
+ screenPosition(WebFloatPoint(globalXParam, globalYParam)) {}
WebMouseEvent(Type typeParam,
WebFloatPoint position,
@@ -59,10 +55,8 @@ class WebMouseEvent : public WebInputEvent, public WebPointerProperties {
modifiersParam,
timeStampSecondsParam),
WebPointerProperties(buttonParam, PointerType::Mouse),
- x(position.x),
- y(position.y),
- globalX(globalPosition.x),
- globalY(globalPosition.y),
+ position(position),
+ screenPosition(globalPosition),
clickCount(clickCountParam) {}
WebMouseEvent(Type typeParam,
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | ui/events/blink/blink_event_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698