Make InsertIncrementalTextCommand to handle surrogate pair

Make InsertIncrementalTextCommand to handle surrogate pair properly

This patch makes |InsertIncrementalTextCommand| to handle surrogate pairs
properly. Before this patch, |InsertIncrementalTextCommand| to attempt to
replace trailing surrogate pairs code unit with surrogate pair then produces
surrogate pairs + trailing surrogate pair.

Example:
Old text: replace D83D DE3A (U+1F63A) by D83D DE38 (U+1F638)
Current behavior: D83D DE3A DE38
New behavior: D83D DE38

This is cause by computeCommonPrefixLength(oldString, newString) returns
1 in above example where middle of surrogate pairs.

BUG=706166
TEST=run_webkit_unit_tests --gtest_filter=InsertIncrementalTextCommandTest.SurrogatePairs*

Review-Url: https://codereview.chromium.org/2782823002
Cr-Commit-Position: refs/heads/master@{#461382}
Committed: https://chromium.googlesource.com/chromium/src/+/1cc2c7d24ced1b58e047a4dea8a78493e32a1bf0

[yosin_UTC9, 2017-03-29 07:14:45]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-03-29 07:14:58]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 07:15:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-29 08:04:16]

Description was changed from

==========
2017-03-29T15:43:58

2017-03-29T15:43:33

BUG=
==========

to

==========
Make InsertIncrementalTextCommand to handle surrogate pair properly

This patch makes |InsertIncrementalTextCommand| to handle surrogate pairs
properly. Before this patch, |InsertIncrementalTextCommand| to attempt to
replace trailing surrogate pairs code unit with surrogate pair then produces
surrogate pairs + trailing surrogate pair.

Example:
Old text: replace D83D DE3A (U+1F63A) by D83D DE38 (U+1F638)
Current behavior: D83D DE3A DE38
New behavior: D83D DE38

This is cause by computeCommonPrefixLength(oldString, newString) returns
1 in above example where middle of surrogate pairs.

BUG=706166
TEST=run_webkit_unit_tests
--gtest_filter=InsertIncrementalTextCommandTest.SurrogatePairs*
==========

[yosin_UTC9, 2017-03-29 08:04:27]

yosin@chromium.org changed reviewers:
+ changwan@chromium.org

[yosin_UTC9, 2017-03-29 08:04:28]

PTAL

[commit-bot: I haz the power, 2017-03-29 08:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 08:58:05]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2017-03-29 15:36:57]

lgtm

https://codereview.chromium.org/2782823002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp
(right):

https://codereview.chromium.org/2782823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp:42:
if (str1[length1 - index - 1] != str2[length2 - index - 1])
Could you consider doing the same for this function?

[yosin_UTC9, 2017-04-03 05:27:28]

Thanks for reviewing!

Committing...

https://codereview.chromium.org/2782823002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp
(right):

https://codereview.chromium.org/2782823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp:42:
if (str1[length1 - index - 1] != str2[length2 - index - 1])
On 2017/03/29 at 15:36:57, Changwan Ryu wrote:
> Could you consider doing the same for this function?

I'll do in another patch.

[yosin_UTC9, 2017-04-03 05:27:30]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-04-03 05:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 07:32:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491197250513400,
"parent_rev": "041854ff2d817f981b08b33fca1bf20168c49cb2", "commit_rev":
"1cc2c7d24ced1b58e047a4dea8a78493e32a1bf0"}

[commit-bot: I haz the power, 2017-04-03 07:33:51]

Description was changed from

==========
Make InsertIncrementalTextCommand to handle surrogate pair properly

This patch makes |InsertIncrementalTextCommand| to handle surrogate pairs
properly. Before this patch, |InsertIncrementalTextCommand| to attempt to
replace trailing surrogate pairs code unit with surrogate pair then produces
surrogate pairs + trailing surrogate pair.

Example:
Old text: replace D83D DE3A (U+1F63A) by D83D DE38 (U+1F638)
Current behavior: D83D DE3A DE38
New behavior: D83D DE38

This is cause by computeCommonPrefixLength(oldString, newString) returns
1 in above example where middle of surrogate pairs.

BUG=706166
TEST=run_webkit_unit_tests
--gtest_filter=InsertIncrementalTextCommandTest.SurrogatePairs*
==========

to

==========
Make InsertIncrementalTextCommand to handle surrogate pair properly

This patch makes |InsertIncrementalTextCommand| to handle surrogate pairs
properly. Before this patch, |InsertIncrementalTextCommand| to attempt to
replace trailing surrogate pairs code unit with surrogate pair then produces
surrogate pairs + trailing surrogate pair.

Example:
Old text: replace D83D DE3A (U+1F63A) by D83D DE38 (U+1F638)
Current behavior: D83D DE3A DE38
New behavior: D83D DE38

This is cause by computeCommonPrefixLength(oldString, newString) returns
1 in above example where middle of surrogate pairs.

BUG=706166
TEST=run_webkit_unit_tests
--gtest_filter=InsertIncrementalTextCommandTest.SurrogatePairs*

Review-Url: https://codereview.chromium.org/2782823002
Cr-Commit-Position: refs/heads/master@{#461382}
Committed:
https://chromium.googlesource.com/chromium/src/+/1cc2c7d24ced1b58e047a4dea8a7...
==========

[commit-bot: I haz the power, 2017-04-03 07:33:52]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1cc2c7d24ced1b58e047a4dea8a7...