Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2782743002: [CrOS Tether] Ensure that BleAdvertiser explicitly calls Unregister() on all advertisements after t… (Closed)

Created:
3 years, 8 months ago by Kyle Horimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Ensure that BleAdvertiser explicitly calls Unregister() on all advertisements after they are done being used. The previous implementation relied on the BluetoothAdvertisement's destructor calling Unregister(), but there are some situations in which the BLE framework holds onto references to the advertisements, resulting in their destructors not being called. This fix explicitly calls Unregister() on each advertisement. BUG=672263 Review-Url: https://codereview.chromium.org/2782743002 Cr-Commit-Position: refs/heads/master@{#460439} Committed: https://chromium.googlesource.com/chromium/src/+/08a3b590f839b9f93d421b65a0570067b7b604c9

Patch Set 1 #

Patch Set 2 : Remove a few out of date comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -11 lines) Patch
M chromeos/components/tether/ble_advertiser.h View 1 5 chunks +25 lines, -1 line 0 comments Download
M chromeos/components/tether/ble_advertiser.cc View 1 4 chunks +33 lines, -7 lines 0 comments Download
M chromeos/components/tether/ble_advertiser_unittest.cc View 8 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Kyle Horimoto
3 years, 8 months ago (2017-03-28 22:38:41 UTC) #2
Ryan Hansberry
lgtm lgtm
3 years, 8 months ago (2017-03-29 00:13:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782743002/20001
3 years, 8 months ago (2017-03-29 00:14:34 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-29 00:14:35 UTC) #7
Jeremy Klein
lgtm
3 years, 8 months ago (2017-03-29 00:19:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782743002/20001
3 years, 8 months ago (2017-03-29 00:22:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/410306)
3 years, 8 months ago (2017-03-29 00:31:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782743002/20001
3 years, 8 months ago (2017-03-29 16:58:26 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:29:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08a3b590f839b9f93d421b65a057...

Powered by Google App Engine
This is Rietveld 408576698