MouseWheelEventQueue sends scrollEnd right away when latching is disabled.

MouseWheelEventQueue sends scrollEnd right away when latching is disabled.

When latching is disabled, instead of setting a timer with zero timeout
to send the scrollEnd event, we send the event right away.
This change has happened to prevent unittests from unintentionally
simulating the latching behavior when it's disabled.

BUG=706175
Review-Url: https://codereview.chromium.org/2782733002
Cr-Commit-Position: refs/heads/master@{#460516}
Committed: https://chromium.googlesource.com/chromium/src/+/08255cfdfb2e98ead2c82b2d0c9e12b9409d8d5b

[sahel, 2017-03-28 22:21:37]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:22:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:47:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sahel, 2017-03-29 14:11:26]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:11:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 14:58:59]

Dry run: This issue passed the CQ dry run.

[sahel, 2017-03-29 15:16:55]

sahel@chromium.org changed reviewers:
+ dtapuska@chromium.org, tdresser@chromium.org

[sahel, 2017-03-29 15:16:55]

dtapuska@chromium.org: Please review changes in 

tdresser@chromium.org: Please review changes in

[tdresser, 2017-03-29 16:55:32]

LGTM

https://codereview.chromium.org/2782733002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/input_router_impl_unittest.cc (right):

https://codereview.chromium.org/2782733002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/input_router_impl_unittest.cc:1036: // There
should be a ScrollEnd sent
Missing "."

Same below.

[sahel, 2017-03-29 17:01:04]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:01:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-03-29 17:49:03]

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/input_router_impl_unittest.cc (right):

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/input_router_impl_unittest.cc:1036: // There
should be a ScrollEnd sent.
Can we adjust this comment so it indicates the GestureScrollEnd is released from
the queue?

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/input_router_impl_unittest.cc:1058: // There
should be a ScrollEnd sent.
Same.. the event is already "sent" from the mouse_wheel_event_queue not just
from the gesture event queue.

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right):

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue.cc:249:
DCHECK(scroll_transaction_ms_ == 0);
DCHECK_EQ(0, scroll_transaction_ms_) is preferred.

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
(left):

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc:620:
EXPECT_FALSE(event_in_flight());
This test is a little odd cause it is called WheelScrollLatching. Should we
return early for this test? It is unclear what it is doing when latching is
disabled.

[sahel, 2017-03-29 17:51:17]

The CQ bit was unchecked by sahel@chromium.org

[sahel, 2017-03-29 18:10:43]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:11:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:08:27]

Dry run: This issue passed the CQ dry run.

[sahel, 2017-03-29 20:10:43]

https://codereview.chromium.org/2782733002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/input_router_impl_unittest.cc (right):

https://codereview.chromium.org/2782733002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/input_router_impl_unittest.cc:1036: // There
should be a ScrollEnd sent
On 2017/03/29 16:55:32, tdresser wrote:
> Missing "."
> 
> Same below.

Done.

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/input_router_impl_unittest.cc (right):

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/input_router_impl_unittest.cc:1036: // There
should be a ScrollEnd sent.
On 2017/03/29 17:49:03, dtapuska wrote:
> Can we adjust this comment so it indicates the GestureScrollEnd is released
from
> the queue?

Done.

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/input_router_impl_unittest.cc:1058: // There
should be a ScrollEnd sent.
On 2017/03/29 17:49:03, dtapuska wrote:
> Same.. the event is already "sent" from the mouse_wheel_event_queue not just
> from the gesture event queue.

Done.

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right):

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue.cc:249:
DCHECK(scroll_transaction_ms_ == 0);
On 2017/03/29 17:49:03, dtapuska wrote:
> DCHECK_EQ(0, scroll_transaction_ms_) is preferred.

Done.

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
(left):

https://codereview.chromium.org/2782733002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc:620:
EXPECT_FALSE(event_in_flight());
On 2017/03/29 17:49:03, dtapuska wrote:
> This test is a little odd cause it is called WheelScrollLatching. Should we
> return early for this test? It is unclear what it is doing when latching is
> disabled.

Done.

[sahel, 2017-03-29 20:12:21]

The CQ bit was checked by sahel@chromium.org

[sahel, 2017-03-29 20:12:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2782733002/#ps40001
(title: "review comments addressed.")

[commit-bot: I haz the power, 2017-03-29 20:13:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-03-29 20:20:13]

On 2017/03/29 20:13:32, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm

[commit-bot: I haz the power, 2017-03-29 20:21:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490818341829690,
"parent_rev": "a542c2ef2954f2ffdcf742842fa79a99e1d9701c", "commit_rev":
"08255cfdfb2e98ead2c82b2d0c9e12b9409d8d5b"}

[commit-bot: I haz the power, 2017-03-29 20:22:15]

Description was changed from

==========
MouseWheelEventQueue sends scrollEnd right away when latching is disabled.

When latching is disabled, instead of setting a timer with zero timeout
to send the scrollEnd event, we send the event right away.
This change has happened to prevent unittests from unintentionally
simulating the latching behavior when it's disabled.

BUG=706175
==========

to

==========
MouseWheelEventQueue sends scrollEnd right away when latching is disabled.

When latching is disabled, instead of setting a timer with zero timeout
to send the scrollEnd event, we send the event right away.
This change has happened to prevent unittests from unintentionally
simulating the latching behavior when it's disabled.

BUG=706175

Review-Url: https://codereview.chromium.org/2782733002
Cr-Commit-Position: refs/heads/master@{#460516}
Committed:
https://chromium.googlesource.com/chromium/src/+/08255cfdfb2e98ead2c82b2d0c9e...
==========

[commit-bot: I haz the power, 2017-03-29 20:22:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/08255cfdfb2e98ead2c82b2d0c9e...

[sahel, 2017-06-15 21:32:06]

Patchset #4 (id:60001) has been deleted