Increase the websocket timeout in Chrome OS.

Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many Chrome
OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS Chrome
to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=trybot

Review-Url: https://codereview.chromium.org/2782683003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/83f447ccc94dc3a0998f62569933f909ec7b069f

[Shuhei Takahashi, 2017-03-29 09:25:51]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:25:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 09:48:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 09:48:17]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2017-03-29 09:54:04]

nya@chromium.org changed reviewers:
+ nednguyen@google.com

[Shuhei Takahashi, 2017-03-29 09:54:05]

nednguyen: PTAL

[nednguyen, 2017-03-29 10:03:26]

On 2017/03/29 09:54:05, Shuhei Takahashi wrote:
> nednguyen: PTAL

This seems very wrong. This is an internal method of Telemetry, and I don't want
to make every aspect in Telemetry code base configurable, especially not through
command line flag. What are you trying to do here?

[Shuhei Takahashi, 2017-03-29 10:12:38]

On 2017/03/29 10:03:26, nednguyen wrote:
> On 2017/03/29 09:54:05, Shuhei Takahashi wrote:
> > nednguyen: PTAL
> 
> This seems very wrong. This is an internal method of Telemetry, and I don't
want
> to make every aspect in Telemetry code base configurable, especially not
through
> command line flag. What are you trying to do here?

Hmm, sorry, it seems I still don't understand what is an expected way in
Telemetry...

I just want to temporarily increase the timeout of websocket connection
attempted by SystemInfoBackend. Could you please give me an advice about how to
do it?


Background:

In ToT Chrome OS Chrome, we have an issue that Chrome occasionally does not
respond to websocket connections for 10+ seconds (http://crbug.com/704024),
causing Chrome OS autotests to fail randomly. Though we are working on the
proper fixes (see the bug), we expect it to take some time. Thus, meanwhile, we
want to workaround the issue by temporarily increase the timeout.

[nednguyen, 2017-03-29 10:17:44]

On 2017/03/29 10:12:38, Shuhei Takahashi wrote:
> On 2017/03/29 10:03:26, nednguyen wrote:
> > On 2017/03/29 09:54:05, Shuhei Takahashi wrote:
> > > nednguyen: PTAL
> > 
> > This seems very wrong. This is an internal method of Telemetry, and I don't
> want
> > to make every aspect in Telemetry code base configurable, especially not
> through
> > command line flag. What are you trying to do here?
> 
> Hmm, sorry, it seems I still don't understand what is an expected way in
> Telemetry...
> 
> I just want to temporarily increase the timeout of websocket connection
> attempted by SystemInfoBackend. Could you please give me an advice about how
to
> do it?
> 
> 
> Background:
> 
> In ToT Chrome OS Chrome, we have an issue that Chrome occasionally does not
> respond to websocket connections for 10+ seconds (http://crbug.com/704024),
> causing Chrome OS autotests to fail randomly. Though we are working on the
> proper fixes (see the bug), we expect it to take some time. Thus, meanwhile,
we
> want to workaround the issue by temporarily increase the timeout.

You can add some if else statment in the place that call SystemInfoBackend(),
s.t like:
if browser is chromeOs:  # TODO(..): remove this condional branch once
crbug.com/704024 is fixed.
   getSystemInfoBackend(timeout=30)
else:
   getSystemInfoBackend()

[Shuhei Takahashi, 2017-03-29 10:20:01]

On 2017/03/29 10:17:44, nednguyen wrote:
> On 2017/03/29 10:12:38, Shuhei Takahashi wrote:
> > On 2017/03/29 10:03:26, nednguyen wrote:
> > > On 2017/03/29 09:54:05, Shuhei Takahashi wrote:
> > > > nednguyen: PTAL
> > > 
> > > This seems very wrong. This is an internal method of Telemetry, and I
don't
> > want
> > > to make every aspect in Telemetry code base configurable, especially not
> > through
> > > command line flag. What are you trying to do here?
> > 
> > Hmm, sorry, it seems I still don't understand what is an expected way in
> > Telemetry...
> > 
> > I just want to temporarily increase the timeout of websocket connection
> > attempted by SystemInfoBackend. Could you please give me an advice about how
> to
> > do it?
> > 
> > 
> > Background:
> > 
> > In ToT Chrome OS Chrome, we have an issue that Chrome occasionally does not
> > respond to websocket connections for 10+ seconds (http://crbug.com/704024),
> > causing Chrome OS autotests to fail randomly. Though we are working on the
> > proper fixes (see the bug), we expect it to take some time. Thus, meanwhile,
> we
> > want to workaround the issue by temporarily increase the timeout.
> 
> You can add some if else statment in the place that call SystemInfoBackend(),
> s.t like:
> if browser is chromeOs:  # TODO(..): remove this condional branch once
> crbug.com/704024 is fixed.
>    getSystemInfoBackend(timeout=30)
> else:
>    getSystemInfoBackend()

Oh I see, then I'll update the patch accordingly. Thanks for your comment!

[Shuhei Takahashi, 2017-03-29 10:29:56]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 10:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2017-03-29 10:32:56]

Description was changed from

==========
Allow configuring timeout of GetSystemInfo().

Currently Telemetry does not provide a way to configure timeout
of GetSystemInfo(). This change adds a browser option for it.

Note that adding an argument to
ChromeBrowserBackend.GetSystemInfo() does not work because it is
called internally from the constructor (via _LogBrowserInfo()).

BUG=chromium:705399
TEST=third_party/catapult/telemetry/bin/run_tests
==========

to

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many
Chrome OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS
Chrome to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=third_party/catapult/telemetry/bin/run_tests
==========

[Shuhei Takahashi, 2017-03-29 10:33:45]

Description was changed from

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many
Chrome OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS
Chrome to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=third_party/catapult/telemetry/bin/run_tests
==========

to

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many Chrome
OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS Chrome
to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=third_party/catapult/telemetry/bin/run_tests
==========

[nednguyen, 2017-03-29 10:38:42]

lgtm

[Shuhei Takahashi, 2017-03-29 10:40:14]

Description was changed from

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many Chrome
OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS Chrome
to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=third_party/catapult/telemetry/bin/run_tests
==========

to

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many Chrome
OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS Chrome
to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=trybot
==========

[commit-bot: I haz the power, 2017-03-29 10:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:52:20]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2017-03-29 10:57:07]

The CQ bit was checked by nya@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:57:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 10:58:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490785027651660,
"parent_rev": "fdb402a3169a4786b1826c3595371f3c4f753bed", "commit_rev":
"83f447ccc94dc3a0998f62569933f909ec7b069f"}

[commit-bot: I haz the power, 2017-03-29 10:58:45]

Description was changed from

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many Chrome
OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS Chrome
to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=trybot
==========

to

==========
Increase the websocket timeout in Chrome OS.

In ToT Chrome OS Chrome, we have an issue that Chrome
occasionally does not respond to websocket connections for
10+ seconds (http://crbug.com/704024), causing many Chrome
OS autotests to fail randomly.
 
This change increases the timeout only for Chrome OS Chrome
to workaround the issue while we work on proper fixes.

BUG=chromium:705399
TEST=trybot

Review-Url: https://codereview.chromium.org/2782683003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-03-29 10:58:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...