Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/offline_pages/core/background/request_queue.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_queue.cc
diff --git a/components/offline_pages/core/background/request_queue.cc b/components/offline_pages/core/background/request_queue.cc
index bdf205453c24de53e2db1cfd77800f15c1f33110..bac52ae5abb31a0b2824b63f8b81236da4f9b7ae 100644
--- a/components/offline_pages/core/background/request_queue.cc
+++ b/components/offline_pages/core/background/request_queue.cc
@@ -31,10 +31,6 @@ void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback,
std::vector<std::unique_ptr<SavePageRequest>> requests) {
GetRequestsResult result =
success ? GetRequestsResult::SUCCESS : GetRequestsResult::STORE_FAILURE;
- // TODO(fgorski): Filter out expired requests based on policy.
- // This may trigger the purging if necessary.
- // Also this may be turned into a method on the request queue or add a policy
- // parameter in the process.
callback.Run(result, std::move(requests));
}
@@ -78,8 +74,6 @@ void RequestQueue::GetRequests(const GetRequestsCallback& callback) {
void RequestQueue::AddRequest(const SavePageRequest& request,
const AddRequestCallback& callback) {
- // TODO(fgorski): check that request makes sense.
- // TODO(fgorski): check that request does not violate policy.
std::unique_ptr<AddRequestTask> task(new AddRequestTask(
store_.get(), request, base::Bind(&AddRequestDone, callback, request)));
task_queue_.AddTask(std::move(task));

Powered by Google App Engine
This is Rietveld 408576698