chrome/browser/android/offline_pages/request_coordinator_factory.cc - Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc ('k') | components/offline_pages/core/background/request_queue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc

diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc

index 2648078e6021cb2d666532be12050bca8b425d25..238467580866a7a81c3adc8430ca4ffeabeed7ac 100644

--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc

+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc

@@ -82,8 +82,6 @@ KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(

net::NetworkQualityEstimator::NetworkQualityProvider*

network_quality_estimator =

UINetworkQualityEstimatorServiceFactory::GetForProfile(profile);

- // TODO(fgorski): Something needs to keep the handle to the Notification

- // dispatcher.

RequestCoordinator* request_coordinator = new RequestCoordinator(

std::move(policy), std::move(offliner), std::move(queue),

std::move(scheduler), network_quality_estimator);