Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2782663002: [Presentation API] Move sandbox check to PresentationRequest constructor. (Closed)

Created:
3 years, 8 months ago by mark a. foltz
Modified:
3 years, 8 months ago
Reviewers:
imcheng
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] Move sandbox check to PresentationRequest constructor. Fix PresentationRequest_sandboxing_error.html. [Patched from https://codereview.chromium.org/2780583003] BUG=705170 Review-Url: https://codereview.chromium.org/2782663002 Cr-Commit-Position: refs/heads/master@{#460460} Committed: https://chromium.googlesource.com/chromium/src/+/e29fdab2cf168e2a4de8709aea221cf5ef65cf5f

Patch Set 1 #

Patch Set 2 : Replace previous iframe tests with simpler ones. #

Total comments: 2

Patch Set 3 : Respond to imcheng@ comments #

Messages

Total messages: 22 (10 generated)
mark a. foltz
3 years, 8 months ago (2017-03-28 18:21:06 UTC) #3
mark a. foltz
We can probably remove the iframe*.html tests. They look redundant with the tests added in ...
3 years, 8 months ago (2017-03-28 18:34:22 UTC) #4
imcheng
lgtm
3 years, 8 months ago (2017-03-28 18:50:22 UTC) #5
mark a. foltz
On 2017/03/28 at 18:50:22, imcheng wrote: > lgtm PTAL at the current patch which replaces ...
3 years, 8 months ago (2017-03-28 20:01:07 UTC) #6
imcheng
still lgtm https://codereview.chromium.org/2782663002/diff/20001/third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html File third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html (right): https://codereview.chromium.org/2782663002/diff/20001/third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html#newcode16 third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html:16: window.addEventListener("message", t.step_func_done(e => { nit: use single ...
3 years, 8 months ago (2017-03-28 20:24:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782663002/40001
3 years, 8 months ago (2017-03-28 21:40:11 UTC) #10
mark a. foltz
https://codereview.chromium.org/2782663002/diff/20001/third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html File third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html (right): https://codereview.chromium.org/2782663002/diff/20001/third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html#newcode16 third_party/WebKit/LayoutTests/presentation/presentation-request-iframe-default-success.html:16: window.addEventListener("message", t.step_func_done(e => { On 2017/03/28 at 20:24:32, imcheng ...
3 years, 8 months ago (2017-03-28 21:40:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/393449)
3 years, 8 months ago (2017-03-28 22:07:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782663002/40001
3 years, 8 months ago (2017-03-28 22:30:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/376989)
3 years, 8 months ago (2017-03-28 22:53:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782663002/40001
3 years, 8 months ago (2017-03-29 17:05:13 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:21:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e29fdab2cf168e2a4de8709aea22...

Powered by Google App Engine
This is Rietveld 408576698