Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2782643004: Clarify comments regarding overflow in svg.css (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify comments regarding overflow in svg.css BUG=701654 Review-Url: https://codereview.chromium.org/2782643004 Cr-Commit-Position: refs/heads/master@{#460632} Committed: https://chromium.googlesource.com/chromium/src/+/d92200ae8377ef1deeee84401f0ac5352c5e7b64

Patch Set 1 #

Total comments: 4

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/svg.css View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
chrishtr
3 years, 8 months ago (2017-03-29 21:13:34 UTC) #3
fs
BUG=... ref missing a digit (7?) LGTM w/ nits. https://codereview.chromium.org/2782643004/diff/1/third_party/WebKit/Source/core/css/svg.css File third_party/WebKit/Source/core/css/svg.css (right): https://codereview.chromium.org/2782643004/diff/1/third_party/WebKit/Source/core/css/svg.css#newcode44 third_party/WebKit/Source/core/css/svg.css:44: ...
3 years, 8 months ago (2017-03-29 21:35:01 UTC) #4
chrishtr
https://codereview.chromium.org/2782643004/diff/1/third_party/WebKit/Source/core/css/svg.css File third_party/WebKit/Source/core/css/svg.css (right): https://codereview.chromium.org/2782643004/diff/1/third_party/WebKit/Source/core/css/svg.css#newcode44 third_party/WebKit/Source/core/css/svg.css:44: Note that here "root svg element" means a frame ...
3 years, 8 months ago (2017-03-30 00:43:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782643004/20001
3 years, 8 months ago (2017-03-30 00:44:38 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 02:59:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d92200ae8377ef1deeee84401f0a...

Powered by Google App Engine
This is Rietveld 408576698