Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2782613002: Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (Closed)

Created:
3 years, 8 months ago by bradnelson
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (patchset #10 id:180001 of https://codereview.chromium.org/2771183002/ ) Reason for revert: Fails on gc-stress. Original issue's description: > [wasm][asm.js] Fix and enable several asm.js tests with the new parser. > > Fix a few items broken during review of scanner + parser: > * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit). > * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO). > > Also fix: > * Drop test based on constant expression evaluation in main parser > * Support constant defined based on existing constant. > * Type constants as signed. > * Added a check that all used functions are defined eventually. > * Zone allocate strings for simplicity (TODOs to refactor better). > > BUG=v8:6090 > BUG=v8:4203 > R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2771183002 > Cr-Commit-Position: refs/heads/master@{#44200} > Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df TBR=clemensh@chromium.org,bradnelson@google.com,marja@chromium.org,mstarzinger@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6090 Review-Url: https://codereview.chromium.org/2782613002 Cr-Commit-Position: refs/heads/master@{#44201} Committed: https://chromium.googlesource.com/v8/v8/+/f8973f1caab084beb4ba35c4f4822dff61aae45f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -73 lines) Patch
M src/asmjs/asm-parser.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/asmjs/asm-parser.cc View 11 chunks +17 lines, -63 lines 0 comments Download
M src/asmjs/asm-scanner.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 chunk +17 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bradnelson
Created Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser.
3 years, 8 months ago (2017-03-28 17:03:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782613002/1
3 years, 8 months ago (2017-03-28 17:04:03 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:04:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f8973f1caab084beb4ba35c4f4822dff61a...

Powered by Google App Engine
This is Rietveld 408576698